feat: implement core workflow runtime components and unit tests#81
Merged
feat: implement core workflow runtime components and unit tests#81
Conversation
…flow and runtime descriptors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several structural and code quality improvements to the builder classes in the
ServerlessWorkflow.Sdk.Buildersnamespace, and also updates solution configuration files. The changes focus on making builder classes sealed, simplifying field usage, improving encapsulation, and moving towards a new solution format.Builder Class Improvements:
AuthenticationPolicyDefinitionBuilder,BackoffStrategyDefinitionBuilder,BasicAuthenticationSchemeDefinitionBuilder, andBearerAuthenticationSchemeDefinitionBuilderare now marked assealedfor better encapsulation and to prevent inheritance where not intended. [1] [2] [3] [4]virtualkeyword where overriding is not required, and by using direct field access instead of property setters/getters. [1] [2] [3] [4] [5]Build()methods have been updated for clarity and correctness, including improved null checks and direct assignment from private fields. [1] [2] [3] [4] [5]Solution and Configuration Updates:
ServerlessWorkflow.Sdk.sln) has been removed, and a new solution file in.slnxformat (ServerlessWorkflow.Sdk.slnx) has been added, reflecting a migration to a new project structure and tooling. [1] [2].claude/settings.local.jsonfile has been added to specify allowed shell commands and permissions, likely for local development or automation tooling.These changes collectively improve code maintainability, safety, and project organization.