[Fix #1489] Serializing java defined files#1514
Draft
fjtirado wants to merge 3 commits into
Draft
Conversation
2b3ca98 to
307fdd4
Compare
Signed-off-by: fjtirado <ftirados@ibm.com>
eaa816f to
ebbb43f
Compare
Signed-off-by: fjtirado <ftirados@ibm.com>
25d3e50 to
59f0dbc
Compare
fjtirado
commented
Jul 6, 2026
Comment on lines
+39
to
+41
| boolean isEnabled = mapper.isEnabled(SerializationFeature.FAIL_ON_EMPTY_BEANS); | ||
| if (isEnabled) { | ||
| mapper.configure(SerializationFeature.FAIL_ON_EMPTY_BEANS, false); |
Collaborator
Author
There was a problem hiding this comment.
As stupid as it migh seem, disable fail_on_empty_bean has to be disabled when the method is non static and belongs to a java class with no fields
fjtirado
commented
Jul 6, 2026
Comment on lines
+64
to
+68
| } finally { | ||
| if (isEnabled) { | ||
| mapper.configure(SerializationFeature.FAIL_ON_EMPTY_BEANS, true); | ||
| } | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
And here we restore the original value (I guess AI will freak out, lets see)
Signed-off-by: fjtirado <ftirados@ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1489