Complete OAuth2 authorization support#1446
Open
mcruzdev wants to merge 8 commits into
Open
Conversation
Signed-off-by: Matheus Cruz <matheuscruz.dev@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds broader OAuth2 workflow support and samples, including JWT-based client authentication and token-exchange parameters, and expands request building to carry revocation/introspection endpoint URIs.
Changes:
- Add workflow sample YAMLs for
client_secret_jwt,private_key_jwt, and token exchange grant. - Implement JWT client assertion handling and token-exchange subject/actor parameters in request building.
- Extend OAuth request URI resolution to include revocation/introspection URIs; add JUnit coverage for new samples.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| impl/test/src/test/resources/workflows-samples/oauth2/oAuthPrivateKeyJwtClientCredentialsHttpCall.yaml | Adds sample workflow using private_key_jwt client auth for client credentials. |
| impl/test/src/test/resources/workflows-samples/oauth2/oAuthClientSecretPostTokenExchangeHttpCall.yaml | Adds sample workflow for token exchange grant with subject/actor tokens. |
| impl/test/src/test/resources/workflows-samples/oauth2/oAuthClientSecretJwtClientCredentialsHttpCall.yaml | Adds sample workflow using client_secret_jwt client auth for client credentials. |
| impl/test/src/test/java/io/serverlessworkflow/impl/test/OAuthHTTPWorkflowDefinitionTest.java | Adds tests validating form-encoded token request bodies for JWT client auth and token exchange. |
| impl/core/src/main/java/io/serverlessworkflow/impl/auth/OAuthRequestBuilder.java | Adds revocation/introspection URI resolution alongside token URI. |
| impl/core/src/main/java/io/serverlessworkflow/impl/auth/JwtClientAssertion.java | Introduces handler that maps provided JWT assertions to RFC7523 form params. |
| impl/core/src/main/java/io/serverlessworkflow/impl/auth/HttpRequestInfoBuilder.java | Extends request info to include revocation/introspection URIs. |
| impl/core/src/main/java/io/serverlessworkflow/impl/auth/HttpRequestInfo.java | Adds revocation/introspection URI fields to the record. |
| impl/core/src/main/java/io/serverlessworkflow/impl/auth/ClientSecretHandler.java | Allows token exchange grant through existing client-secret handlers. |
| impl/core/src/main/java/io/serverlessworkflow/impl/auth/AuthUtils.java | Adds constants for assertion and token-exchange related param names. |
| impl/core/src/main/java/io/serverlessworkflow/impl/auth/AbstractAuthRequestBuilder.java | Implements JWT assertion auth method selection + subject/actor param forwarding. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+67
to
+69
| private static String endpointPath(String path, String defaultPath) { | ||
| return path != null ? path.replaceAll("^/", "") : defaultPath; | ||
| } |
fjtirado
reviewed
Jun 10, 2026
fjtirado
reviewed
Jun 10, 2026
Comment on lines
+69
to
+80
| void accept(Map<String, Object> secret) { | ||
| Map<String, Object> client = asClient(secret); | ||
| if (client == null || client.get(ASSERTION) == null) { | ||
| throw new IllegalArgumentException( | ||
| "A client assertion must be provided for JWT client authentication"); | ||
| } | ||
| if (PASSWORD.value().equals(secret.get(GRANT))) { | ||
| password(secret); | ||
| } else { | ||
| clientCredentials(secret); | ||
| } | ||
| } |
Comment on lines
+67
to
+69
| private static String endpointPath(String path, String defaultPath) { | ||
| return path != null ? path.replaceAll("^/", "") : defaultPath; | ||
| } |
| "actor_token_type=urn:ietf:params:oauth:token-type:access_token")); | ||
| } | ||
|
|
||
| private String runJwtClientAuthWorkflow(String workflowResource) throws Exception { |
Comment on lines
+48
to
+52
| requestBuilder | ||
| .withUri(endpointResolver(uri, endpointPath(token, DEFAULT_TOKEN_PATH))) | ||
| .withRevocationUri(endpointResolver(uri, endpointPath(revocation, DEFAULT_REVOCATION_PATH))) | ||
| .withIntrospectionUri( | ||
| endpointResolver(uri, endpointPath(introspection, DEFAULT_INTROSPECTION_PATH))); |
Signed-off-by: Matheus Cruz <matheuscruz.dev@gmail.com>
Signed-off-by: Matheus Cruz <matheuscruz.dev@gmail.com>
Signed-off-by: Matheus Cruz <matheuscruz.dev@gmail.com>
Signed-off-by: Matheus Cruz <matheuscruz.dev@gmail.com>
Comment on lines
+119
to
+123
| () -> { | ||
| Response response = executeRequest(workflowContext, taskContext, model); | ||
| ensureSuccessful(response, taskContext, "obtain token"); | ||
| return response.readEntity(new GenericType<>() {}); | ||
| }); |
fjtirado
reviewed
Jun 11, 2026
Comment on lines
+42
to
+43
| throw new UnsupportedOperationException( | ||
| "Token introspection is not supported by this provider"); |
Collaborator
There was a problem hiding this comment.
Since this is an internal interface, there is not need (I know AI complaints but lets ignore this) to use this kind of antipattern consisting on providing a default implementaiton that is not implementation at all just to keep all implementos compiling (which is not a concern here)
Signed-off-by: Matheus Cruz <matheuscruz.dev@gmail.com>
fjtirado
reviewed
Jun 12, 2026
Collaborator
There was a problem hiding this comment.
I think this one can be rolleck back (the db files wont appear after you rebase)
fjtirado
approved these changes
Jun 12, 2026
Signed-off-by: Matheus Cruz <matheuscruz.dev@gmail.com>
| * <p>{@code active} is the only field guaranteed by the specification; the full response is exposed | ||
| * through {@code claims} so callers can inspect additional metadata (scope, exp, sub, ...). | ||
| */ | ||
| public record TokenIntrospection(boolean active, Map<String, Object> claims) {} |
Comment on lines
+169
to
+189
| private Response postManagementRequest( | ||
| WorkflowContext workflow, | ||
| TaskContext task, | ||
| WorkflowModel model, | ||
| URI uri, | ||
| String token, | ||
| String tokenTypeHint) { | ||
| Invocation.Builder builder = | ||
| commonHeaders(HttpClientResolver.client(workflow, task).target(uri), workflow, task, model); | ||
|
|
||
| Form form = new Form(); | ||
| form.param("token", token); | ||
| if (tokenTypeHint != null) { | ||
| form.param("token_type_hint", tokenTypeHint); | ||
| } | ||
| requestInfo | ||
| .clientAuthParams() | ||
| .forEach((key, value) -> form.param(key, value.apply(workflow, task, model))); | ||
|
|
||
| return builder.post(Entity.entity(form, MediaType.APPLICATION_FORM_URLENCODED)); | ||
| } |
Comment on lines
+206
to
+218
| private URI endpoint( | ||
| Optional<WorkflowValueResolver<URI>> resolver, | ||
| String name, | ||
| WorkflowContext workflow, | ||
| TaskContext task, | ||
| WorkflowModel model) { | ||
| return resolver | ||
| .map(r -> r.apply(workflow, task, model)) | ||
| .orElseThrow( | ||
| () -> | ||
| new UnsupportedOperationException( | ||
| "No " + name + " endpoint is configured for this provider")); | ||
| } |
| assertTrue(tokenRequestBody.contains("password=serverless-workflow-test")); | ||
| assertTrue(tokenRequestBody.contains("client_id=serverless-workflow")); | ||
| assertTrue(tokenRequestBody.contains("client_secret=D0ACXCUKOUrL5YL7j6RQWplMaSjPB8MT")); | ||
| assertTrue(tokenRequestBody.contains("client_secret=dummy-secret-for-tests")); |
| Map.of( | ||
| "clientId", "serverless-workflow", | ||
| "clientSecret", "D0ACXCUKOUrL5YL7j6RQWplMaSjPB8MT", | ||
| "clientSecret", "dummy-secret-for-tests", |
| assertTrue( | ||
| asJson.containsKey("client_secret") | ||
| && asJson.get("client_secret").equals("D0ACXCUKOUrL5YL7j6RQWplMaSjPB8MT")); | ||
| && asJson.get("client_secret").equals("dummy-secret-for-tests")); |
| Map.of( | ||
| "clientId", "serverless-workflow", | ||
| "clientSecret", "D0ACXCUKOUrL5YL7j6RQWplMaSjPB8MT"); | ||
| "clientSecret", "dummy-secret-for-tests"); |
| assertTrue( | ||
| asJson.containsKey("client_secret") | ||
| && asJson.get("client_secret").equals("D0ACXCUKOUrL5YL7j6RQWplMaSjPB8MT")); | ||
| && asJson.get("client_secret").equals("dummy-secret-for-tests")); |
| Map.of( | ||
| "clientId", "serverless-workflow", | ||
| "clientSecret", "D0ACXCUKOUrL5YL7j6RQWplMaSjPB8MT"); | ||
| "clientSecret", "dummy-secret-for-tests"); |
| assertTrue( | ||
| asJson.containsKey("client_secret") | ||
| && asJson.get("client_secret").equals("D0ACXCUKOUrL5YL7j6RQWplMaSjPB8MT")); | ||
| && asJson.get("client_secret").equals("dummy-secret-for-tests")); |
Signed-off-by: Matheus Cruz <matheuscruz.dev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Many thanks for submitting your Pull Request ❤️!
What this PR does / why we need it:
private_key_jwtandclient_secret_jwt.Special notes for reviewers:
Additional information (if needed):
Closes #1003