Skip to content

meta: update all npm dependencies#833

Merged
WikiRik merged 17 commits intomainfrom
ephys/update-dependencies
Apr 5, 2026
Merged

meta: update all npm dependencies#833
WikiRik merged 17 commits intomainfrom
ephys/update-dependencies

Conversation

@ephys
Copy link
Copy Markdown
Member

@ephys ephys commented Apr 4, 2026

There are a bunch of individual dependency updates that are failing, but their changes are easy to fix.

Instead of fixing each PR individually, here is a PR that fixes everything.

I also added .idea to always enable eslint & prettier in that IDE

@ephys ephys requested a review from a team as a code owner April 4, 2026 19:18
@ephys ephys requested review from WikiRik and sdepold April 4, 2026 19:18
@ephys ephys marked this pull request as draft April 4, 2026 19:21
@WikiRik
Copy link
Copy Markdown
Member

WikiRik commented Apr 4, 2026

I'm used to having .idea folder in the gitignored files because it's often accidentally committed when contributors set up different configurations. I'm also not a user of Jetbrains projects when working on sequelize/open source work. So I'm not sure if we should change that.

@WikiRik
Copy link
Copy Markdown
Member

WikiRik commented Apr 4, 2026

Should we update CI as well? Versions of Node and the actions

@ephys
Copy link
Copy Markdown
Member Author

ephys commented Apr 4, 2026

I reduced the number of .idea files to just allow the eslint & prettier configuration

Edit: Also aligned the renovate config with the one from the main repo

@WikiRik
Copy link
Copy Markdown
Member

WikiRik commented Apr 4, 2026

I reduced the number of .idea files to just allow the eslint & prettier configuration

I think that's fine. Can we update the gitignore to only allow those specific files?

@ephys
Copy link
Copy Markdown
Member Author

ephys commented Apr 4, 2026

I did, but as a result I ignored the .gitignore :D

@ephys
Copy link
Copy Markdown
Member Author

ephys commented Apr 4, 2026

Everything seems updated now

The only thing I did not update is actions/create-github-app-token@v2, because it seems to require a dependency update in Sequelize 6 first: https://github.com/sequelize/website/actions/runs/23985683221/job/69957153351?pr=831

Edit: nevermind, another issue. Looks like we need to update yarn on Sequelize 6 as well

@ephys ephys marked this pull request as ready for review April 4, 2026 19:43
@WikiRik
Copy link
Copy Markdown
Member

WikiRik commented Apr 4, 2026

Should we make the API reference for v6 static as well? Hopefully we're not going to make that many more changes that affect it

@ephys
Copy link
Copy Markdown
Member Author

ephys commented Apr 4, 2026

If it becomes too much of a headache, yes - but I would keep it until we promote v7 to stable if we can

Edit: and they're already starting. We can't use that version of yarn in v6, because it uses an old node version: sequelize/sequelize#18188

@WikiRik
Copy link
Copy Markdown
Member

WikiRik commented Apr 4, 2026

Edit: and they're already starting. We can't use that version of yarn in v6, because it uses an old node version: sequelize/sequelize#18188

That's what I expected. Otherwise we'd likely already be using yarn 2+ on this repo

Edit: I do agree that it would be better to keep it until v6 is not getting security updates anymore

@ephys ephys changed the title meta: update all npm dependencies & yarn meta: update all npm dependencies Apr 4, 2026
@ephys
Copy link
Copy Markdown
Member Author

ephys commented Apr 4, 2026

Looks like even without the yarn upgrade, I can't install Sequelize 6 anymore

@ephys ephys mentioned this pull request Apr 4, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 5, 2026

🚀 Website draft URL
📋 Deployment logs

@WikiRik WikiRik enabled auto-merge (squash) April 5, 2026 10:45
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 5, 2026

🚀 Website draft URL
📋 Deployment logs

@WikiRik WikiRik merged commit 6adf42d into main Apr 5, 2026
5 checks passed
@WikiRik WikiRik deleted the ephys/update-dependencies branch April 5, 2026 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants