Skip to content

fix(noderesource): use apiGroup in rbac-proxy config (not group) #274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bdchatham merged 1 commit into from
May 18, 2026
Merged

fix(noderesource): use apiGroup in rbac-proxy config (not group) #274

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions internal/noderesource/noderesource.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1013,10 +1013,10 @@ func proxyReadinessProbe() *corev1.Probe {

// GenerateRBACProxyConfigMap produces the ConfigMap carrying the
// kube-rbac-proxy authorization config — a single coarse SAR scoped
// to (group=sei.io, resource=seinodetasks, namespace=<ns>, name=<node>).
// Verb is derived from HTTP method by the proxy. Bypass paths live on
// the proxy's --ignore-paths CLI flag, not this file (config-file
// allowedPaths gates at the authz layer and still requires authn).
// to (apiGroup=sei.io, resource=seinodetasks, namespace=<ns>, name=<node>).
// Verb is derived from HTTP method by the proxy. The field name is
// `apiGroup`, matching kube-rbac-proxy's authz.ResourceAttributes
// struct (pkg/authz/auth.go).
//
// `name` scopes the SAR to the specific SeiNode so operators can bind
// ClusterRoles with resourceNames to narrow access per-validator;
Expand All @@ -1025,7 +1025,7 @@ func GenerateRBACProxyConfigMap(node *seiv1alpha1.SeiNode) *corev1.ConfigMap {
config := strings.Join([]string{
"authorization:",
" resourceAttributes:",
" group: sei.io",
" apiGroup: sei.io",
" resource: seinodetasks",
" namespace: " + node.Namespace,
" name: " + node.Name,
Expand Down
6 changes: 3 additions & 3 deletions internal/noderesource/sidecar_proxy_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,12 +85,12 @@ func TestServicePorts_AlwaysIncludesAPIPort(t *testing.T) {
g.Expect(found).To(BeTrue(), "headless Service must publish the proxy API port")
}

func TestGenerateRBACProxyConfigMap_UsesGroupNotApiGroup(t *testing.T) {
func TestGenerateRBACProxyConfigMap_UsesApiGroup(t *testing.T) {
g := NewWithT(t)
cm := GenerateRBACProxyConfigMap(newGenesisNode("a", "default"))
g.Expect(cm).NotTo(BeNil())
g.Expect(cm.Data["config.yaml"]).To(ContainSubstring("group: sei.io"),
"resourceAttributes uses 'group', not 'apiGroup' — kube-rbac-proxy unmarshals SAR ResourceAttributes, the field name is group")
g.Expect(cm.Data["config.yaml"]).To(ContainSubstring("apiGroup: sei.io"),
"field name must match kube-rbac-proxy's authz.ResourceAttributes struct (apiGroup, not group)")
}

func TestGenerateStatefulSet_ProxyImageMissing_Errors(t *testing.T) {
Expand Down
Loading