feat(docker): add Prometheus + Grafana monitoring compose overlay#3436
feat(docker): add Prometheus + Grafana monitoring compose overlay#3436amir-deris wants to merge 6 commits into
Conversation
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3436 +/- ##
==========================================
+ Coverage 59.29% 59.31% +0.02%
==========================================
Files 2125 2118 -7
Lines 175629 174715 -914
==========================================
- Hits 104144 103639 -505
+ Misses 62404 62039 -365
+ Partials 9081 9037 -44
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
PR SummaryLow Risk Overview Introduces Reviewed by Cursor Bugbot for commit c924ea1. Bugbot is set up for automated code reviews on this repo. Configure here. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
There are 2 total unresolved issues (including 1 from previous review).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 1f70ad0. Configure here.
| else \ | ||
| DETACH_FLAG=""; \ | ||
| fi; \ | ||
| DOCKER_PLATFORM=$(DOCKER_PLATFORM) USERID=$(shell id -u) GROUPID=$(shell id -g) GOCACHE=$(shell go env GOCACHE) NUM_ACCOUNTS=10 INVARIANT_CHECK_INTERVAL=${INVARIANT_CHECK_INTERVAL} UPGRADE_VERSION_LIST=${UPGRADE_VERSION_LIST} MOCK_BALANCES=${MOCK_BALANCES} GIGA_EXECUTOR=${GIGA_EXECUTOR} GIGA_OCC=${GIGA_OCC} RECEIPT_BACKEND=${RECEIPT_BACKEND} AUTOBAHN=${AUTOBAHN} GIGA_STORAGE=${GIGA_STORAGE} docker compose -f docker-compose.yml -f docker-compose.monitoring.yml up --no-attach grafana --no-attach prometheus $$DETACH_FLAG |
There was a problem hiding this comment.
Monitoring target duplicates entire cluster-start recipe body
Low Severity
The docker-cluster-start-monitoring target copy-pastes the entire body of docker-cluster-start — cleanup steps, directory creation, detach-flag logic, and a long inline list of ~10 environment variables (INVARIANT_CHECK_INTERVAL, GIGA_EXECUTOR, AUTOBAHN, etc.). The only difference is the compose file arguments and --no-attach flags. When a new feature-flag env var is added to docker-cluster-start, it can easily be forgotten in the monitoring target, causing silent behavioral differences between the two cluster modes.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 1f70ad0. Configure here.


Summary
docker/docker-compose.monitoring.yaml— a compose overlay that attaches Prometheus and Grafana to the existinglocalnetnetwork alongside the 4-node local clusterdocker/docker_compose_monitoring/prometheus.yaml— scrape config targeting all four nodes (sei-node-{0-3}:1317) at 5 s intervalsdocker/docker_compose_monitoring/grafana-datasource.yaml— auto-provisions Prometheus as the default Grafana datasource on startupmake docker-cluster-start-monitoring/make docker-cluster-stop-monitoringMakefile targets and updatesdocker/README.mdto document the combined workflow alongside the existing script-based alternativeNote
Low Risk
Low risk: adds optional local Docker Compose monitoring services and make targets without changing chain/runtime logic or production configuration.
Overview
Adds a
docker-compose.monitoring.ymloverlay that runs Prometheus and Grafana on the existinglocalnetnetwork, including a Prometheus scrape config for all four local nodes and a provisioned Grafana Prometheus datasource.Introduces
make docker-cluster-start-monitoring/make docker-cluster-stop-monitoringto bring the cluster + monitoring stack up/down in one command, and updatesdocker/README.mdto document the combined workflow alongside the existing script-based approach.Reviewed by Cursor Bugbot for commit a314fb0. Bugbot is set up for automated code reviews on this repo. Configure here.