add passthrough router#3430
Merged
Merged
Conversation
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3430 +/- ##
==========================================
+ Coverage 59.28% 59.36% +0.08%
==========================================
Files 2118 2113 -5
Lines 175556 174387 -1169
==========================================
- Hits 104078 103528 -550
+ Misses 62407 61851 -556
+ Partials 9071 9008 -63
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
blindchaser
approved these changes
May 13, 2026
Kbhat1
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
When integrating routers with
composite.Store, I realized there was an edge case we hadn't considered. There are test apps (e.g.SimApp) that use different module names than expected. In order to keep those test apps working, I needed to introduce thePassthroughRouter, which skips all module name checking. We can use the passthrough router when operating with a single database backend, since we really only care about restricting module names during migration.Testing performed to validate your change
unit tests
Note
Medium Risk
Changes routing behavior for
MemiavlOnly/FlatKVOnlyto stop validating module names, which could alter error surfaces and allow unexpected store names to reach the backend. Scope is localized to the migration router layer and covered by new unit tests.Overview
Adds a new
PassthroughRouterthat forwardsRead,ApplyChangeSets,Iterator, andGetProofdirectly to provided accessors (and returns explicit errors when iteration/proofs are unsupported).Updates
BuildRouterto use this passthrough behavior inMemiavlOnlyandFlatKVOnlymodes (instead ofModuleRoutername checks) to keep compatibility with apps that use nonstandard store names, and generalizes flatkv wiring by acceptingflatkv.Storerather than*flatkv.CommitStore. Includes comprehensive unit tests asserting name-agnostic forwarding and error propagation.Reviewed by Cursor Bugbot for commit a77ea81. Bugbot is set up for automated code reviews on this repo. Configure here.