fix(core): keep events buffered when a WaitingPlugin is added before … - #1321
Open
abueide wants to merge 1 commit into
Open
fix(core): keep events buffered when a WaitingPlugin is added before …#1321abueide wants to merge 1 commit into
abueide wants to merge 1 commit into
Conversation
…init A WaitingPlugin added right after createClient() is deferred into pluginsToAdd and only registered from onReady(). init() then set running to true and drained the pending buffer unconditionally, discarding the pause the plugin had just requested, so events were enriched with the plugin's pre-resume() state. init() now leaves processing paused while waiting plugins are registered, and pauseEventProcessing() arms its auto-resume timeout even when processing is already stopped so the 30s safety valve still applies pre-init. resumeEventProcessing() defers the buffer drain to init() until isReady. Fixes #1308 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…init
A WaitingPlugin added right after createClient() is deferred into pluginsToAdd and only registered from onReady(). init() then set running to true and drained the pending buffer unconditionally, discarding the pause the plugin had just requested, so events were enriched with the plugin's pre-resume() state.
init() now leaves processing paused while waiting plugins are registered, and pauseEventProcessing() arms its auto-resume timeout even when processing is already stopped so the 30s safety valve still applies pre-init. resumeEventProcessing() defers the buffer drain to init() until isReady.
Fixes #1308