ci: actually run the tests on Packit again #4927
Merged
gpotter2 merged 2 commits intosecdev:masterfrom Feb 20, 2026
Merged
Conversation
The Fedora package added the "%check" section to the spec file to perform an import check in https://src.fedoraproject.org/rpms/scapy/c/878585466261f17c01516a653d19cf47022c2f9f?branch=rawhide and it broke the upstream script where sed expected the "%check" section to be commented out. This patch adjusts the sed command to run the tests again.
Currently those tests sporadically time out in some Packit jobs. They can probably be brought back once Packit is stabilized.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4927 +/- ##
==========================================
- Coverage 80.63% 80.63% -0.01%
==========================================
Files 370 370
Lines 91733 91733
==========================================
- Hits 73972 73970 -2
- Misses 17761 17763 +2 🚀 New features to boost your workflow:
|
Member
|
Thanks a lot for the PR ! Regarding the failing test... Ahh, yes, that moment when PyPy segfaults.. |
Ebrix
pushed a commit
to Ebrix/scapy
that referenced
this pull request
Feb 26, 2026
* ci: actually run the tests on Packit again The Fedora package added the "%check" section to the spec file to perform an import check in https://src.fedoraproject.org/rpms/scapy/c/878585466261f17c01516a653d19cf47022c2f9f?branch=rawhide and it broke the upstream script where sed expected the "%check" section to be commented out. This patch adjusts the sed command to run the tests again. * ci: turn off netaccess on Packit for now Currently those tests sporadically time out in some Packit jobs. They can probably be brought back once Packit is stabilized.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Fedora package added the "%check" section to the spec file to
perform an import check in
https://src.fedoraproject.org/rpms/scapy/c/878585466261f17c01516a653d19cf47022c2f9f?branch=rawhide
and it broke the upstream script where sed expected the "%check" section
to be commented out. This patch adjusts the sed command to run the tests
again.
The "netaccess" tests are turned off for now because they sporadically time out in some Packit jobs.
They can probably be brought back once Packit is stabilized.
It was tested in https://copr.fedorainfracloud.org/coprs/packit/evverx-scapy-2/build/10153843/.