test: use "@pytest.mark.complete" where applicable - #1726
Merged
Conversation
In "test/t/{test_make.py,unit/test_compgen_filedir_xspec.py}", the
plain "completion = assert_complete(...)" can be replaced with
"@pytest.mark.complete" markers.
For "test/t/unit/test_unit_compgen_{commands,filedir}.py", the
"class"-scope fixture "functions" are ensured to be initialized before
the "function"-scope fixture "completion", so we can use "completion"
even when the test relies on "functions".
[1] scop#1715 (comment)
akinomyoga
force-pushed
the
pytest.mark.complete
branch
from
August 13, 2026 17:18
e2fae71 to
abc010a
Compare
scop
approved these changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1715 (comment)
I've checked all the occurrences of
completion =. I realized that those were mainly added by me, in particular inclass TestMake2andclass TestUnitFiledirXspec. The otherTestMake*were copied by followers.