Skip to content

feat(cockpit): add alloy config snippet generation for metrics, logs and traces - #5638

Merged
elwinar merged 1 commit into
mainfrom
feat/cockpit-config-alloy
Oct 13, 2026
Merged

elwinar merged 1 commit into
mainfrom
feat/cockpit-config-alloy

Conversation

@jremy42

@jremy42 jremy42 commented Jun 4, 2026 •

Copy link
Copy Markdown
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #5498

feat(cockpit): generate Grafana Alloy config snippets for metrics, logs and traces

@jremy42
jremy42 requested review from a team and remyleone as code owners June 4, 2026 14:23
@codecov-commenter

codecov-commenter commented Jun 4, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 43.75000% with 63 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.64%. Comparing base (6104780) to head (f5fb495).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...nternal/namespaces/cockpit/v1/custom_config_get.go 0.00% 42 Missing ⚠️
...ernal/namespaces/cockpit/v1/custom_config_alloy.go 67.92% 13 Missing and 4 partials ⚠️
...spaces/cockpit/v1/custom_config_alloy_templates.go 76.47% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5638      +/-   ##
==========================================
- Coverage   50.65%   50.64%   -0.01%     
==========================================
  Files         340      342       +2     
  Lines       78127    78238     +111     
==========================================
+ Hits        39577    39626      +49     
- Misses      37054    37110      +56     
- Partials     1496     1502       +6     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread internal/namespaces/cockpit/v1/custom_config_alloy.go Outdated
@remyleone
remyleone marked this pull request as draft June 15, 2026 11:19
@github-code-quality

github-code-quality Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

Code Coverage Overview

Languages: Go

Go / cli

The overall line coverage in commit 330c7a8 in the feat/cockpit-config-... branch remains at 49%, unchanged from commit 26816c1 in the main branch.

Show a line coverage summary of the most impacted files.
File main 26816c1 feat/cockpit-config-... 330c7a8 +/-
internal/namesp...m_config_get.go 28% 25% -3%
internal/namesp...oy_templates.go 0% 81% +81%
internal/namesp...config_alloy.go 0% 86% +86%

Updated October 13, 2026 14:50 UTC

@jremy42
jremy42 marked this pull request as ready for review October 13, 2026 13:14
@elwinar
elwinar force-pushed the feat/cockpit-config-alloy branch 4 times, most recently from d674207 to 06e86cc Compare October 13, 2026 13:33
@elwinar
elwinar force-pushed the feat/cockpit-config-alloy branch from 186c38c to 6fd0d41 Compare October 13, 2026 14:43
@elwinar
elwinar force-pushed the feat/cockpit-config-alloy branch from 6fd0d41 to 330c7a8 Compare October 13, 2026 14:46
@elwinar
elwinar added this pull request to the merge queue Oct 13, 2026
Merged via the queue into main with commit be92ace Oct 13, 2026
2 checks passed
@elwinar
elwinar deleted the feat/cockpit-config-alloy branch October 13, 2026 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for configuring alloy for metrics, logs and traces

4 participants