Improve testing and documentation - #266
Open
palemieux wants to merge 10 commits into
Open
Conversation
palemieux
force-pushed
the
feature/improve-reference-rendering-generation
branch
from
August 31, 2026 21:30
a704024 to
31851b1
Compare
Merged
palemieux
force-pushed
the
feature/improve-reference-rendering-generation
branch
from
September 1, 2026 17:20
a872271 to
33beb9c
Compare
CI's actions/checkout step never set submodules: true, so src/test/resources/imsc-tests (a git submodule) was checked out empty. grunt build's sync task had nothing to copy, leaving tests.json and the TTML fixtures missing from build/public_html and causing every headless render/reference-file test to 404 on the first fetch.
Comparison script
Contributor
Author
|
@ littlespex Wanna have a look? |
Contributor
|
does this provide images which match the actual browser output now? |
Contributor
Author
Not yet. This could be a next step. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.