Skip to content

Bump veewee/xml version to support PHP 8.5#41

Open
Opblaasmaatje wants to merge 1 commit intosaloonphp:v1from
Opblaasmaatje:chore/bump-veewee-xml
Open

Bump veewee/xml version to support PHP 8.5#41
Opblaasmaatje wants to merge 1 commit intosaloonphp:v1from
Opblaasmaatje:chore/bump-veewee-xml

Conversation

@Opblaasmaatje
Copy link
Copy Markdown

@Opblaasmaatje Opblaasmaatje commented Mar 30, 2026

PHP 8.5 does not seem to be supported yet.

Bumping the version should allow support for it.

See spec complaince of veewee/xml

image

@Opblaasmaatje
Copy link
Copy Markdown
Author

Opblaasmaatje commented Mar 30, 2026

I also see this PR which is super nice. You might still need this bumb though? I am not entirely sure though! :-)

@stanleykinkelaar
Copy link
Copy Markdown

Need this too! veewee/xml also has later versions already but this version supports PHP 8.5. Thanks @Opblaasmaatje .

@veewee
Copy link
Copy Markdown
Collaborator

veewee commented Mar 30, 2026

Hello there,

Just wanted to tune in to the conversation:

  • Spec compliance is only available starting from v4 (which has >= PHP 84 support)
  • I will slowly be sunsetting the v3 branch now that PHP 83 is coming to an unsupported state, meaning that the spec compliant version will become the default one and you might need to upgrade the internals of this library.

I don't see the purpose of this PR given that ^3.1 includes ^3.3?
But it might make sense to create a PR to introduce veewee/xml ^4.0 support (that drops the 3.x range). Downside would be that this is PHP 8.4+ only.

@Opblaasmaatje
Copy link
Copy Markdown
Author

Thank you for taking your time to reply! :-)

  • Spec compliance is only available starting from v4 (which has >= PHP 84 support)
  • I will slowly be sunsetting the v3 branch now that PHP 83 is coming to an unsupported state, meaning that the spec compliant version will become the default one and you might need to upgrade the internals of this library.

Ah, I see. I did not read the first part... hahaha

Nevertheless, I figured ugrading to ^3.3 would be OK, seeing as it shouldn't drop any support for any already supported PHP version on saloon/xml-wrangler, and it should allow upgrading to PHP8.5 wouldn't it? :-)

I am not very knowledgeable in package development... haha :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants