feat: expand dataspace-scoped dependency closure at deploy time - #1621
Open
himanshu-shekhar wants to merge 2 commits into
Open
feat: expand dataspace-scoped dependency closure at deploy time#1621himanshu-shekhar wants to merge 2 commits into
himanshu-shekhar wants to merge 2 commits into
Conversation
Data Cloud dataspace-scoped types (CalculatedInsight, DataModelObject) declare dependencies inline (a CI dependsOn its DataModelObject(s)). When deploying such a component, its referenced dependencies must ride along in the same deploy, but nothing else in the project should. executeDeploy now expands the requested ComponentSet with just the transitive dataspace-scoped dependency closure via SDR's expandDataspaceScopedComponentSet. Requests with no dataspace-scoped components return untouched (cheap no-op for every other deploy). Depends on forcedotcom/source-deploy-retrieve#1816, which adds the dataspaceScoped adapter/transformer and expandDataspaceScopedComponentSet.
|
Thanks for the contribution! Before we can merge this, we need @himanshu-shekhar to sign the Salesforce Inc. Contributor License Agreement. |
… the default deploy path
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Data Cloud dataspace-scoped types (CalculatedInsight, DataModelObject) declare dependencies inline (a CI dependsOn its DataModelObject(s)). When deploying such a component, its referenced dependencies must ride along in the same deploy, but nothing else in the project should.
executeDeploy now expands the requested ComponentSet with just the transitive dataspace-scoped dependency closure via SDR's expandDataspaceScopedComponentSet. Requests with no dataspace-scoped components return untouched (cheap no-op for every other deploy).
Depends on forcedotcom/source-deploy-retrieve#1816, which adds the dataspaceScoped adapter/transformer and expandDataspaceScopedComponentSet.
What does this PR do?
What issues does this PR fix or reference?