Extract jib plugin to its own subproject#342
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
com.ryandens.javaagent-jibplugin out of thepluginsubproject into two new subprojects:jib-common(the Jib extension logic, shared with a future tiny-jib plugin) andjib(the Gradle plugin entry point that wiresJavaagentJibExtensioninto Jib's plugin extension mechanism)JavaagentJibPluginas a thinPlugin<Project>wrapper in thejibsubproject, sojib-commoncan remain a pure library dependency for a future tiny-jib pluginpluginUnderTestMetadatain:jibnow explicitly depends on:jib-common:jarand:plugin:jarJibExtensionConfiguration.javathat was left behind in thepluginsubprojectTest plan
./gradlew :jib:buildpasses (unit + functional tests)./gradlew :plugin:buildpasses (no jib references remain)./gradlew buildpasses across all subprojects🤖 Generated with Claude Code