Skip to content

clean up features - #607

Open
Freax13 wants to merge 14 commits into
rust-osdev:nextfrom
Freax13:feature-cleanup
Open

Freax13 wants to merge 14 commits into
rust-osdev:nextfrom
Freax13:feature-cleanup

Conversation

@Freax13

@Freax13 Freax13 commented Sep 16, 2026

Copy link
Copy Markdown
Member

This PR removes some of the features that are no longer needed and removes nightly from the set of default features.

dependabot Bot and others added 6 commits June 29, 2026 19:42
Bumps [actions/cache](https://github.com/actions/cache) from 5 to 6.
- [Release notes](https://github.com/actions/cache/releases)
- [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md)
- [Commits](actions/cache@v5...v6)

---
updated-dependencies:
- dependency-name: actions/cache
  dependency-version: '6'
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
…ctions/actions/cache-6

Bump actions/cache from 5 to 6
`cargo-semver-checks` only supports stable officially. Nightly works sometimes, but there are errors when some signature etc changes on nightly and stable still has the old variant. Given that the `Step` trait is still actively worked on, it's better to skip it during the check to avoid errors.
@Freax13 Freax13 mentioned this pull request Sep 16, 2026

@phil-opp phil-opp left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Freax13
Freax13 force-pushed the feature-cleanup branch 2 times, most recently from 71bbc4f to 35efa85 Compare September 17, 2026 17:04
@Freax13
Freax13 force-pushed the feature-cleanup branch 4 times, most recently from ac164a7 to 5a63b26 Compare September 17, 2026 17:18
const_fn has been stabilized.
asm_const has been stabilized.
Now that the nightly feature is no longer enabled by default, we need
to enable it manually.

Let's run the tests with and without the nightly feature.
@Freax13

Freax13 commented Sep 17, 2026

Copy link
Copy Markdown
Member Author

CI failed for a bunch of different reasons because there was a bunch of work left. That's now done. @phil-opp please take another look

@Freax13
Freax13 requested a review from phil-opp September 17, 2026 17:46

@phil-opp phil-opp left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants