uefi: bump from 0.20 to 0.38#566
Open
phip1611 wants to merge 1 commit into
Open
Conversation
- improve code structure - use more helpers - use modern uefi library APIs
Member
Author
|
what do we do about the semver CI issue? |
Member
|
The semver CI job fails also on main. |
Freax13
reviewed
Jul 6, 2026
Freax13
left a comment
Freax13
left a comment
Member
There was a problem hiding this comment.
Thanks, this is great work!
Sorry for the delay.
| unsafe { slice::from_raw_parts_mut(ptr.as_mut(), size) } | ||
| } | ||
|
|
||
| fn open_pxe_base_code() -> Option<boot::ScopedProtocol<BaseCode>> { |
Member
There was a problem hiding this comment.
This is subtly changing the behavior isn't it? Previously, we opened the BaseCode handle that was used to load the base image, but now we're looking at all BaseCode handles, right? If a system has more than one network interface (e.g. a wireless one and a wired one), this could change which interface is used to load the files, right?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bump the outdated uefi code to a much newer
uefiversion + misc code improvements