Only init ndk-context once with an Application ref#229
Merged
Conversation
Instead of initializing `ndk-context` with an `Activity` reference (for the `android.context.Context` subclass) we now initialize with an `android.app.Application` reference (also an `android.context.Context` subclass). The benefit of this is that we can strictly initialize `ndk-context` once (via a `OnceLock`) so there's no risk of a panic in case an application starts more than one Activity within the same process. Fixes: #58 Fixes: #228
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of initializing
ndk-contextwith anActivityreference (for theandroid.context.Contextsubclass) we now initialize with anandroid.app.Applicationreference (also anandroid.context.Contextsubclass).The benefit of this is that we can strictly initialize
ndk-contextonce (via aOnceLock) so there's no risk of anndk-contextpanic in case an application starts more than one Activity within the same process.For reference; I've tested this change in conjunction with amodm/webbrowser-rs#111 to confirm that the
webbrowsercrate can be made to work with anApplicationorActivityreference (prior to the 1.2 release it expects anActivityand>= 1.2it can handle anActivityorApplicationContext).Fixes: #58
Fixes: #228