Suggest alternative toolchains for unavailable targets - #5094
Open
Sreehari425 wants to merge 1 commit into
Open
Sreehari425 wants to merge 1 commit into
Sreehari425 wants to merge 1 commit into
Conversation
Cloud0310
reviewed
Sep 19, 2026
| } | ||
| } | ||
|
|
||
| fn find_toolchain_with_target(&self, target: &TargetTuple) -> Option<String> { |
Contributor
There was a problem hiding this comment.
Do we use this elsewhere? If not, the same as https://github.com/rust-lang/rustup/pull/5094/changes#r4052997668.
Contributor
Author
There was a problem hiding this comment.
I kept this as a separate helper even though it’s only used here, since I felt moving the toolchain lookup out of remove_components made the function a bit easier to read.
Sreehari425
force-pushed
the
rustup-msg
branch
3 times, most recently
from
September 19, 2026 12:25
c2597ac to
3d12360
Compare
Sreehari425
force-pushed
the
rustup-msg
branch
from
September 19, 2026 12:31
3d12360 to
c6e412e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4164
rustup target remove <target>now suggests another installed toolchain when the target isn't available in the current one. If no other toolchain has the target, the existing error is unchanged.