check mut-restriction when tuple constructor is used as a value - #160928
Open
im-lunex wants to merge 2 commits into
Open
check mut-restriction when tuple constructor is used as a value#160928im-lunex wants to merge 2 commits into
mut-restriction when tuple constructor is used as a value#160928im-lunex wants to merge 2 commits into
Conversation
Collaborator
|
Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt |
rustbot
added
S-waiting-on-review
Collaborator
|
r? @mu001999 rustbot has assigned @mu001999. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This comment has been minimized.
This comment has been minimized.
Urgau
reviewed
Aug 11, 2026
Comment on lines
+41
to
+42
| && let def_kind = self.tcx.def_kind(def_id) | ||
| && let DefKind::Ctor(ctor_of, _) = def_kind |
Member
There was a problem hiding this comment.
Suggested change
| && let def_kind = self.tcx.def_kind(def_id) | |
| && let DefKind::Ctor(ctor_of, _) = def_kind | |
| && let DefKind::Ctor(ctor_of, _) = self.tcx.def_kind(def_id) |
| pub struct Wrapper(pub mut(self) u8); | ||
|
|
||
| pub enum EnumTup { | ||
| Tup(mut(self) u8), |
Member
There was a problem hiding this comment.
Let's add more tests. Like making sure one can still construct EnumTup::Foo and that multi fields works as expected.
Suggested change
| Tup(mut(self) u8), | |
| Tup(mut(self) u8), | |
| Foo(u8), | |
| Bar(u8, mut(crate) u8), |
In general, let's try to be exhaustive.
Member
|
cc @jhpratt @CoCo-Japan-pan |
rustbot
added
S-waiting-on-author
Collaborator
|
Reminder, once the PR becomes ready for a review, use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this fixes a bug where tuple struct constructors could bypass
mutfield restrictions when used as function values instead of being called directly. right nowCheckMutRestrictiononly checks struct expressions likeWrapper(5). but referencinginner::Wrapperas a value was allowed, which let outsiders construct structs with restricted fields.Fixes #160891