Enhance EII UI tests - #160927
Open
AsakuraMizu wants to merge 2 commits into
Open
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
r? @davidtwco rustbot has assigned @davidtwco. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Contributor
Author
|
@rustbot label +F-extern_item_impls |
bjorn3
reviewed
Aug 11, 2026
| @@ -1,4 +1,5 @@ | |||
| //@ no-prefer-dynamic | |||
| //@[dylib] compile-flags: --crate-type=dylib -Cprefer-dynamic | |||
| #![crate_type = "rlib"] | |||
Member
There was a problem hiding this comment.
I believe this and a couple other tests are missing a //@ revisions. In addition I'm not sure if --crate-type or #![crate_type] would win. Pleasw don't use the at the same time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking issue: #125418
LLM disclosure
The first commit was written without LLM assistance.
The second commit was LLM-assisted. I found the issue, designed the overall change and let coding agent do the repetitive updates across the test files.
Description
The first commit enabled all EII tests on Windows MSVC. Two other PRs were merged almost simultaneously with my previous PR and they kept
ignore-windowsinstead ofignore-windows-gnu.The second commit normalized EII dylib test coverage. Previously, there were only two dedicated negative tests and some auxiliary crates that had
no-prefer-dynamicremoved but whosecrate_typewas stillrlibwere accidentally compiled intodylibs and thus were tested unintentionally.This is now normalized: some tests will be tested under two revisions:
rlibanddylibordylib-impl(declaration inrlib& implementation indylib).Note that
call_default_panics.run.stderris not updated; the file appears to be invalid, and I am unsure how to update this check.