Handle multiple action records in EH personality function - #160923
Open
nbdd0121 wants to merge 1 commit into
Open
Handle multiple action records in EH personality function#160923nbdd0121 wants to merge 1 commit into
nbdd0121 wants to merge 1 commit into
Conversation
rustbot
added
S-waiting-on-author
This comment has been minimized.
This comment has been minimized.
Contributor
|
Thanks for fixing this! I did the test on my side and it seems to work. and with this PR, I get the correct behavior in my reproducer. |
nbdd0121
force-pushed
the
eh_personality
branch
from
August 11, 2026 17:43
21dbc6e to
6663fc5
Compare
This comment has been minimized.
This comment has been minimized.
nbdd0121
force-pushed
the
eh_personality
branch
from
August 11, 2026 18:03
6663fc5 to
c25db43
Compare
Member
Author
|
r? bjorn3 perhaps? |
nbdd0121
marked this pull request as ready for review
August 11, 2026 19:11
rustbot
added
S-waiting-on-review
nbdd0121
force-pushed
the
eh_personality
branch
from
August 11, 2026 19:12
c25db43 to
689d39d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LSDA encodes actions are a linked list, we currently only decode the first one. Action records are used for catching specific exception types and for exception specifications, and none of these are present in Rust. However we can still have of multiple of them being present due to LLVM inlining. When this happens, "Catch" is the correct action to execute.
We haven't had issues with this because LLVM orders cleanup record last; however GCC doesn't use the same order, so we do need to explicitly handle this case to support both LLVM and GCC codegen.
See https://rust-lang.zulipchat.com/#narrow/channel/182449-t-compiler.2Fhelp/topic/Possible.20bug.20in.20unwind.20function.20in.20std/with/615883393