Align expect messages with guidance - #159998
Open
pluiee wants to merge 1 commit into
Open
Conversation
Collaborator
|
|
mejrs
requested changes
Jul 27, 2026
| //! | ||
| //! let mut file = File::create("valuable_data.txt").unwrap(); | ||
| //! file.write_all(b"important message").expect("failed to write message"); | ||
| //! file.write_all(b"important message").expect("newly created file should be writable"); |
Contributor
There was a problem hiding this comment.
This is far too specific, you can fail a write for other reasons.
| /// ```ignore (hypothetical-example) | ||
| /// loop { | ||
| /// let (client, request) = get_request().expect("disconnected"); | ||
| /// let (client, request) = get_request().expect("server should stay connected while accepting requests"); |
Contributor
There was a problem hiding this comment.
This line is long enough that the example will get a horizontal scrollbar.
Can you make it shorter?
Collaborator
|
Reminder, once the PR becomes ready for a review, use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #159751
Changed 3
expectmessages and some relevant comments inlibrary/core/src/result.rsandlibrary/core/src/primitive_docs.rsI intentionally left the below snippet unchanged in
library/core/src/result.rs.The example is quite minimal and focuses on showing the panic output format, so I thought it was better to keep the message short and simple.
r? @fee1-dead