Skip to content

On arm, only require fpregs instead of vfp2 to allow s0-s15, s0-s31, and d0-15 register classes - #159988

Open
chrisnc wants to merge 1 commit into
rust-lang:mainfrom
chrisnc:arm-inline-asm-fpregs
Open

On arm, only require fpregs instead of vfp2 to allow s0-s15, s0-s31, and d0-15 register classes#159988
chrisnc wants to merge 1 commit into
rust-lang:mainfrom
chrisnc:arm-inline-asm-fpregs

Conversation

@chrisnc

@chrisnc chrisnc commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Fixes #159976

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 27, 2026
@rustbot

rustbot commented Jul 27, 2026

Copy link
Copy Markdown
Collaborator

r? @wesleywiser

rustbot has assigned @wesleywiser.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 74 candidates
  • Random selection from 16 candidates

@chrisnc
chrisnc force-pushed the arm-inline-asm-fpregs branch from 358e6d5 to ce21e35 Compare July 27, 2026 03:32
@rustbot

This comment has been minimized.

Comment thread tests/assembly-llvm/asm/arm-fpregs.rs Outdated
Comment thread tests/assembly-llvm/asm/arm-fpregs.rs Outdated
Comment thread tests/assembly-llvm/asm/arm-fpregs.rs Outdated
@chrisnc
chrisnc force-pushed the arm-inline-asm-fpregs branch from ce21e35 to 7e6e05e Compare July 27, 2026 16:23
@rustbot

rustbot commented Jul 27, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@rustbot

rustbot commented Jul 27, 2026

Copy link
Copy Markdown
Collaborator

⚠️ Warning ⚠️

  • There are issue links (such as #123) in the commit messages of the following commits.
    Please move them to the PR description, to avoid spamming the issues with references to the commit, and so this bot can automatically canonicalize them to avoid issues with subtree.

@chrisnc chrisnc changed the title On arm, only require the fpregs feature to allow s0-s15, s0-s31, and d0-15 register classes On arm, only require fpregs instead of vfp2 to allow s0-s15, s0-s31, and d0-15 register classes Jul 27, 2026
@chrisnc
chrisnc requested a review from jonathanpallant July 27, 2026 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

armv8r-none-eabihf target cannot use FPU instructions in inline asm

4 participants