Fix too-short variance slice in variances_of cycle recovery#158163
Draft
xmakro wants to merge 1 commit into
Draft
Fix too-short variance slice in variances_of cycle recovery#158163xmakro wants to merge 1 commit into
variances_of cycle recovery#158163xmakro wants to merge 1 commit into
Conversation
rustbot
added
A-query-system
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the cycle-error fallback in
variances_ofto size the slice the same way the provider does invariance/solve.rs:117.This can otherwise ICE under the parallel frontend in
relate_args_with_variancesfor items that inherit their generics from a parent (like a tuple struct constructor). See #154560 (comment)