Clippy subtree update#157779
Merged
Merged
Conversation
the `else` block of `let...else` binding.
Clarify the rationale for fn_params_excessive_bools, document the main replacement patterns, and note that max-fn-params-bools accepts 0 to lint any bool parameter.
*[View all comments](https://triagebot.infra.rust-lang.org/gh-comments/rust-lang/rust-clippy/pull/17066)* Violets are red, Roses are blue, This month is RustWeek, And borrow-checkers too. ---- Unfortunately, no nominations from the previous one 😿 So take it [from 1.94](rust-lang/rust-clippy#16653) <img width="1032" height="1548" alt="image" src="https://github.com/user-attachments/assets/02ba1c12-e712-4d90-8914-ed3a404b094c" /> Pochoclo from @Phosphorus-M doing cat things — because pawsitivity and important meowtters come first 😸 ---- Cats for the next release can be nominated in the comments🙏🙏🙏 changelog: none r? flip1995
Instead of first searching for a '=' and then comparing the slice before, try to match directly and see what's left over. This is probably not at all impactful or even noticeable except for unimaginably huge command lines... changelog:none
*[View all comments](https://triagebot.infra.rust-lang.org/gh-comments/rust-lang/rust-clippy/pull/16257)* This adds a Clippy lint for the possible confusing behaviour pointed out in rust-lang#150084 and rust-lang#111514, and discussed in rust-lang/libs-team#304. While no consensus have been reached in the API Change Proposal linked above I thought that it would still make sense to add a Clippy lint for the time being. Open questions: - Which group should it be in? - Should it give warnings for `AsciiChar`, `Ipv4Addr` and `Ipv6Addr`? (Currently these will always panic when running over the max value) changelog: new lint: [`for_unbounded_range`]
Improve the `fn_params_excessive_bools` docs to better explain why boolean parameters hurt call-site readability and to describe the main replacement patterns: enums for mode selection, separate named operations for distinct behaviors, and structs/options types for grouped flags. This also documents that `max-fn-params-bools = 0` is valid and lints any function with a bool parameter. changelog: [fn_params_excessive_bools]: improve documentation
allows us to do less work, and also enables the next commit
- use `span_lint_and_then`, do more things inside its closure - reuse `SyntaxContext` - use symbols instead of strs
- don't put the suggestion into the main lint message - use verbose suggestions, to avoid awkward span highlighting
- don't put the suggestion into the main lint message - use verbose suggestions, to avoid awkward span highlighting changelog: [`redundant_pattern_match`]: improve suggestions
changelog: none r? ada4a
*[View all comments](https://triagebot.infra.rust-lang.org/gh-comments/rust-lang/rust-clippy/pull/17086)* changelog: none r? ada4a
changelog: none r? ada4a
changelog: none r? ada4a
I've collected too big of a backlog already...
rust-bors
Bot
added
S-waiting-on-review
Contributor
|
💔 Test for 6782e23 failed: CI. Failed job:
|
Collaborator
|
A job failed! Check out the build log: (web) (plain enhanced) (plain) Click to see the possible cause of the failure (guessed by this bot) |
Member
|
@bors retry |
rust-bors
Bot
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
rust-bors Bot
pushed a commit
that referenced
this pull request
Jun 12, 2026
Clippy subtree update r? Manishearth Cargo.lock update due to ui_test bump.
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
rust-bors
Bot
added
S-waiting-on-review
Contributor
|
💔 Test for d28c648 failed: CI. Failed job:
|
Contributor
|
Spurious |
rust-bors
Bot
added
S-waiting-on-bors
Contributor
|
@bors p=6 |
This comment has been minimized.
This comment has been minimized.
rust-bors
Bot
added
merged-by-bors
Contributor
Contributor
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 09a3713 (parent) -> a1e52fc (this PR) Test differencesShow 2 test diffs2 doctest diffs were found. These are ignored, as they are noisy. Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard a1e52fc1cf67929a7c01ed9c037520e276ec98fd --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
This was referenced Jun 12, 2026
Collaborator
|
Finished benchmarking commit (a1e52fc): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)This perf run didn't have relevant results for this metric. CyclesThis perf run didn't have relevant results for this metric. Binary sizeThis perf run didn't have relevant results for this metric. Bootstrap: 517.481s -> 519.113s (0.32%) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r? Manishearth
Cargo.lock update due to ui_test bump.