Avoid unneeded work for storage removal in non-opt builds in CopyProp and GVN#155491
Open
ohadravid wants to merge 1 commit intorust-lang:mainfrom
Open
Avoid unneeded work for storage removal in non-opt builds in CopyProp and GVN#155491ohadravid wants to merge 1 commit intorust-lang:mainfrom
ohadravid wants to merge 1 commit intorust-lang:mainfrom
Conversation
Collaborator
|
Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt |
rustbot
added
S-waiting-on-review
ohadravid
force-pushed
the
faster-storage-in-copyprop-and-gvn
branch
from
544ea18 to
bb8798b
Compare
ohadravid
commented
Apr 18, 2026
| for (local, &head) in ssa.copy_classes().iter_enumerated() { | ||
| if local != head { | ||
| any_replacement = true; | ||
| storage_to_remove.insert(head); |
Contributor
Author
There was a problem hiding this comment.
Before, Replacer used unified to check which locals require storage removal - so this is fine
https://github.com/rust-lang/rust/pull/142531/changes#diff-0004c9822ecc282c9d6f6bcec22d1b50d49c6165e8093c1dbd2607086278dc19L96
ohadravid
force-pushed
the
faster-storage-in-copyprop-and-gvn
branch
from
bb8798b to
2389a3a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix performance regression introduced in #142531 (rust-timer comment) by only allocating local sets for the storage accounting when
tcx.sess.emit_lifetime_markers().r? saethlin