make tests/run-make/used-proc-macro more reliable#155436
Open
japaric wants to merge 1 commit intorust-lang:mainfrom
Open
make tests/run-make/used-proc-macro more reliable#155436japaric wants to merge 1 commit intorust-lang:mainfrom
japaric wants to merge 1 commit intorust-lang:mainfrom
Conversation
rustbot
added
A-run-make
Collaborator
|
r? @mejrs rustbot has assigned @mejrs. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This comment has been minimized.
This comment has been minimized.
the test was relying on the linker not discarding the `#[used]` symbol this commit modifies the proc macro to read the `#[used]` symbol to ensure it is not discarded by the linker
Xylakant
pushed a commit
to ferrocene/ferrocene
that referenced
this pull request
Apr 17, 2026
the test was relying on the linker not discarding the `#[used]` symbol this commit modifies the proc macro to read the `#[used]` symbol to ensure it is not discarded by the linker cherry-picked from upstream, see rust-lang/rust#155436
mejrs
reviewed
Apr 17, 2026
Comment on lines
3
to
+4
| #[used] | ||
| #[no_mangle] // so we can refer to this variable by name from the proc-macro library |
Contributor
There was a problem hiding this comment.
Doesn't #[no_mangle] imply #[used]?
This is not my area of expertise but it looks like you can drop the #[used] attribute (and adjust the comments appropriately). Please correct me if I'm wrong.
Member
There was a problem hiding this comment.
Yeah, #[used] would no longer have much of an effect now.
Xylakant
pushed a commit
to ferrocene/ferrocene
that referenced
this pull request
Apr 17, 2026
the test was relying on the linker not discarding the `#[used]` symbol this commit modifies the proc macro to read the `#[used]` symbol to ensure it is not discarded by the linker cherry-picked from upstream, see rust-lang/rust#155436
mejrs
added
S-waiting-on-author
bjorn3
reviewed
Apr 17, 2026
Comment on lines
+14
to
+19
| // read the symbol otherwise the _linker_ may discard it | ||
| // `#[used]` only preserves the symbol up to the compiler output (.o file) | ||
| // which is then passed to the linker. the linker is free to discard the | ||
| // `#[used]` symbol if it's not accessed/referred-to by other object | ||
| // files (crates) | ||
| let symbol_value = unsafe { core::ptr::addr_of!(VERY_IMPORTANT_SYMBOL).read_volatile() }; |
Member
There was a problem hiding this comment.
#[used] is an alias for #[used(linker)] since #140872, which should prevent the linker from discarding it. In either case now that you added a reference to it in another crate, this test is no longer testing #[used] as it should. The linker error that you observed is a genuine bug that this test caught. This bug should be fixed instead of changing the test.
Xylakant
pushed a commit
to ferrocene/ferrocene
that referenced
this pull request
Apr 18, 2026
the test was relying on the linker not discarding the `#[used]` symbol this commit modifies the proc macro to read the `#[used]` symbol to ensure it is not discarded by the linker cherry-picked from upstream, see rust-lang/rust#155436
Xylakant
pushed a commit
to ferrocene/ferrocene
that referenced
this pull request
Apr 18, 2026
the test was relying on the linker not discarding the `#[used]` symbol this commit modifies the proc macro to read the `#[used]` symbol to ensure it is not discarded by the linker cherry-picked from upstream, see rust-lang/rust#155436
Xylakant
pushed a commit
to ferrocene/ferrocene
that referenced
this pull request
Apr 18, 2026
the test was relying on the linker not discarding the `#[used]` symbol this commit modifies the proc macro to read the `#[used]` symbol to ensure it is not discarded by the linker cherry-picked from upstream, see rust-lang/rust#155436
Xylakant
pushed a commit
to ferrocene/ferrocene
that referenced
this pull request
Apr 18, 2026
the test was relying on the linker not discarding the `#[used]` symbol this commit modifies the proc macro to read the `#[used]` symbol to ensure it is not discarded by the linker cherry-picked from upstream, see rust-lang/rust#155436
Xylakant
pushed a commit
to ferrocene/ferrocene
that referenced
this pull request
Apr 18, 2026
the test was relying on the linker not discarding the `#[used]` symbol this commit modifies the proc macro to read the `#[used]` symbol to ensure it is not discarded by the linker cherry-picked from upstream, see rust-lang/rust#155436
Xylakant
pushed a commit
to ferrocene/ferrocene
that referenced
this pull request
Apr 18, 2026
the test was relying on the linker not discarding the `#[used]` symbol this commit modifies the proc macro to read the `#[used]` symbol to ensure it is not discarded by the linker cherry-picked from upstream, see rust-lang/rust#155436
Xylakant
pushed a commit
to ferrocene/ferrocene
that referenced
this pull request
Apr 18, 2026
the test was relying on the linker not discarding the `#[used]` symbol this commit modifies the proc macro to read the `#[used]` symbol to ensure it is not discarded by the linker cherry-picked from upstream, see rust-lang/rust#155436
Xylakant
pushed a commit
to ferrocene/ferrocene
that referenced
this pull request
Apr 18, 2026
the test was relying on the linker not discarding the `#[used]` symbol this commit modifies the proc macro to read the `#[used]` symbol to ensure it is not discarded by the linker cherry-picked from upstream, see rust-lang/rust#155436
Xylakant
pushed a commit
to ferrocene/ferrocene
that referenced
this pull request
Apr 18, 2026
the test was relying on the linker not discarding the `#[used]` symbol this commit modifies the proc macro to read the `#[used]` symbol to ensure it is not discarded by the linker cherry-picked from upstream, see rust-lang/rust#155436
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the test was relying on the linker not discarding the
#[used]symbolthis commit modifies the proc macro to read the
#[used]symbol to ensure it is not discarded by the linkerfixes #155434