Additional tce tests

[tnuha]

r? @oli-obk

Adds known-bug tests for LLVM emissions regarding indirect operands for TCE. Also includes a test, indexer.rs, referring to function_table behavior described by the RFC.

Depends on #144232

Closes #144293

[rustbot]

oli-obk is not on the review rotation at the moment.
They may take a while to respond.

[rustbot]

Some changes occurred in compiler/rustc_codegen_ssa

cc @WaffleLapkin

Some changes occurred in compiler/rustc_codegen_gcc

cc @antoyo, @GuillaumeGomez

[oli-obk]

You're gonna need the kind of //@normalize-stderr attributes as other ICE tests have, or just add the test to tests/crashes

[WaffleLapkin]

What do you mean by "decision on verbiage"?.. What is this test even testing?

you can make the test pass (hopefully) by just replacing &dyn Fn(usize) with fn(usize)

[tnuha]

"Decision on verbiage" was meant to indicate more discussion on examples given in that part of the RFC. From what I could see, nobody had tested that particular example of tail-calling something from a function table, and I was curious as to whether it'd work as desired, as it's kind of an operation. Didn't look too close in that regard though, admittedly.
I can indicate that better with a new comment, thanks for pointing that out.

Test also does pass with the described change. Push coming in a moment. However, it does feel a little silly to include now, so if input indicates I should remove it, I will. I suppose another approach that would include indexing would be something like a "basic examples from RFC" sort of file, or just appending this behavior to another test.

[WaffleLapkin]

@Borgerr I think you broke something in rebase, since you have a commit which is not yours...

[tnuha]

@rustbot label -S-waiting-on-author +S-waiting-on-review

[WaffleLapkin]

@bors r+

[bors]

📌 Commit caa3cf1 has been approved by WaffleLapkin

It is now in the queue for this repository.

[tnuha]

@rustbot label +S-waiting-on-author -S-waiting-on-review

Wrong issue in file name

[tgross35]

Please give the test a descriptive name, we're trying to move away from test files that only have a number. We can run the try though

@bors2 try jobs=dist-i586-gnu-i586-i686-musl

@rustbot label +S-waiting-on-author -S-waiting-on-review

For future reference, @rustbot author or @rustbot review are aliases to update both labels

[rust-bors]

⌛ Trying commit 27797b1 with merge aab23ff…

To cancel the try build, run the command @bors try cancel.

[rust-bors]

☀️ Try build successful (CI)
Build commit: aab23ff (aab23ffa93515b947f652645af544d32d168a8e4, parent: 29cdc6a109ee98a382f974bf89d3971b4385399c)

[WaffleLapkin]

r? tgross35

[tnuha]

@rustbot ready

Thank you guys again for your patience on this one, this should be it 🙏

[tgross35]

@bors r=WaffleLapkin,tgross35

[bors]

📌 Commit 916fb6a has been approved by WaffleLapkin,tgross35

It is now in the queue for this repository.