fix: correct into_iter() example to compile properly#2001
Merged
marioidival merged 1 commit intorust-lang:masterfrom Apr 1, 2026
Merged
Conversation
The into_iter() example previously used `println!("names: {:?}", names)`
after the collection was consumed, causing a compilation error. Commented
out the offending line with an explanation and removed the `ignore` flag
so the example is now compilable and runnable.
Collaborator
|
r? @marioidival rustbot has assigned @marioidival. Use Why was this reviewer chosen?The reviewer was selected based on:
|
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Apr 6, 2026
Update books ## rust-lang/reference 6 commits in 7446bf9697c95d155eef33c6a9d91fbd29a5e359..d2715c07e9dd9839c0c7675ecfa18bec539a6ee9 2026-03-31 18:18:16 UTC to 2026-03-23 21:49:16 UTC - Guarantee size and alignment of more integer primitives (rust-lang/reference#2205) - [type layout] usize and isize have the same size and alignment (rust-lang/reference#2200) - Update reference for attribute order changes (rust-lang/reference#2213) - Fix note for non_exhaustive enum read (rust-lang/reference#2211) - Update link_name duplicates note (rust-lang/reference#2216) - Note scoping differences between `*x` and `*x.deref()` , and `a[b]` and `*a.index(b)` (rust-lang/reference#2073) ## rust-lang/rust-by-example 8 commits in 5383db524711c0c9c43c3ca9e5e706089672ed6a..b31e3b8da01eeba0460f86a52a55af82709fadf5 2026-04-01 11:59:18 UTC to 2026-03-30 12:17:12 UTC - fix: correct into_iter() example to compile properly (rust-lang/rust-by-example#2001) - fix: correct destruction order comments in Drop TempFile example (rust-lang/rust-by-example#2002) - fix: replace confusing 'module' with 'item' in formatted print docs (rust-lang/rust-by-example#2003) - fix: clarify misleading 'Error' comment in print_display example (rust-lang/rust-by-example#2004) - fix: clarify comment about tuple struct field access in testcase_list (rust-lang/rust-by-example#2005) - fix: correct iter/into_iter type comments in iter_find example (rust-lang/rust-by-example#2006) - fix: replace year-to-days conversion with miles-to-km in newtype example (rust-lang/rust-by-example#2007) - Add a pub use example (rust-lang/rust-by-example#2000)
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Apr 6, 2026
Update books ## rust-lang/reference 6 commits in 7446bf9697c95d155eef33c6a9d91fbd29a5e359..d2715c07e9dd9839c0c7675ecfa18bec539a6ee9 2026-03-31 18:18:16 UTC to 2026-03-23 21:49:16 UTC - Guarantee size and alignment of more integer primitives (rust-lang/reference#2205) - [type layout] usize and isize have the same size and alignment (rust-lang/reference#2200) - Update reference for attribute order changes (rust-lang/reference#2213) - Fix note for non_exhaustive enum read (rust-lang/reference#2211) - Update link_name duplicates note (rust-lang/reference#2216) - Note scoping differences between `*x` and `*x.deref()` , and `a[b]` and `*a.index(b)` (rust-lang/reference#2073) ## rust-lang/rust-by-example 8 commits in 5383db524711c0c9c43c3ca9e5e706089672ed6a..b31e3b8da01eeba0460f86a52a55af82709fadf5 2026-04-01 11:59:18 UTC to 2026-03-30 12:17:12 UTC - fix: correct into_iter() example to compile properly (rust-lang/rust-by-example#2001) - fix: correct destruction order comments in Drop TempFile example (rust-lang/rust-by-example#2002) - fix: replace confusing 'module' with 'item' in formatted print docs (rust-lang/rust-by-example#2003) - fix: clarify misleading 'Error' comment in print_display example (rust-lang/rust-by-example#2004) - fix: clarify comment about tuple struct field access in testcase_list (rust-lang/rust-by-example#2005) - fix: correct iter/into_iter type comments in iter_find example (rust-lang/rust-by-example#2006) - fix: replace year-to-days conversion with miles-to-km in newtype example (rust-lang/rust-by-example#2007) - Add a pub use example (rust-lang/rust-by-example#2000)
rust-timer
added a commit
to rust-lang/rust
that referenced
this pull request
Apr 7, 2026
Rollup merge of #154901 - rustbot:docs-update, r=ehuss Update books ## rust-lang/reference 6 commits in 7446bf9697c95d155eef33c6a9d91fbd29a5e359..d2715c07e9dd9839c0c7675ecfa18bec539a6ee9 2026-03-31 18:18:16 UTC to 2026-03-23 21:49:16 UTC - Guarantee size and alignment of more integer primitives (rust-lang/reference#2205) - [type layout] usize and isize have the same size and alignment (rust-lang/reference#2200) - Update reference for attribute order changes (rust-lang/reference#2213) - Fix note for non_exhaustive enum read (rust-lang/reference#2211) - Update link_name duplicates note (rust-lang/reference#2216) - Note scoping differences between `*x` and `*x.deref()` , and `a[b]` and `*a.index(b)` (rust-lang/reference#2073) ## rust-lang/rust-by-example 8 commits in 5383db524711c0c9c43c3ca9e5e706089672ed6a..b31e3b8da01eeba0460f86a52a55af82709fadf5 2026-04-01 11:59:18 UTC to 2026-03-30 12:17:12 UTC - fix: correct into_iter() example to compile properly (rust-lang/rust-by-example#2001) - fix: correct destruction order comments in Drop TempFile example (rust-lang/rust-by-example#2002) - fix: replace confusing 'module' with 'item' in formatted print docs (rust-lang/rust-by-example#2003) - fix: clarify misleading 'Error' comment in print_display example (rust-lang/rust-by-example#2004) - fix: clarify comment about tuple struct field access in testcase_list (rust-lang/rust-by-example#2005) - fix: correct iter/into_iter type comments in iter_find example (rust-lang/rust-by-example#2006) - fix: replace year-to-days conversion with miles-to-km in newtype example (rust-lang/rust-by-example#2007) - Add a pub use example (rust-lang/rust-by-example#2000)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1904
The
into_iter()example failed to compile becausenameswas used after being moved. Commented out the offendingprintln!with an explanation thatnameshas been consumed and can no longer be used.