add macros for generating Default impls#5257
Open
telcharr wants to merge 6 commits into
Open
Conversation
tgross35
requested changes
Jul 9, 2026
Contributor
There was a problem hiding this comment.
Thank you for putting this together! It looks very workable. I have a handful of requests but all style/maintainability.
Would you be able to add a commit that makes use of this (replacing s!) in a few small places so we make sure it works in situ? Fine to do that in a separate PR, if you prefer, as long as it's coming soon.
Collaborator
|
Reminder, once the PR becomes ready for a review, use |
Author
|
Added a commit converting @rustbot ready |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds
impl_default!,s_with_default!, ands_no_extra_traits_with_default!as a start for #4975. Unions get no implicitDefaultso a union field would need to supply one via#[custom_default(unsafe { mem::zeroed::<U>() })]. As discussed,custom_defaultneeds to be the first attribute on a field since the macro matches it literally.Checklist
libc-test/semverhave been updated*LASTor*MAXareincluded (see #3131)
cd libc-test && cargo test --target mytarget);especially relevant for platforms that may not be checked in CI
@rustbot label +stable-nominated