Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a file
bitwise-lemmas.mdwith lemmas for rewriting bitwise arithmetic expressions (&Int,>>Intand<<Int) into arithmetic operations that the SMT solver can more easily reason about (modInt,/Int,*Int), as well as lemmas for bounding the results of bitwise expressions. Because of how the introduced lemmas interact with previous lemmas defined inkmir-lemmas.md, in particular the lemmas for simplifying round-trip conversions (which are defined in terms of bitwise expressions), we also include lemmas for simplifying such expressions even after being rewritten in terms of non-bitwise operators.The PR also includes new integration tests that exercise the new lemmas, and regenerates
.expectedfiles that are affected (all of them by simplifying out redundant bitmasks).