Repository navigation
Conversation
There was a problem hiding this comment.
馃煝 Approval recommended
No blocking issues were identified in the transport migration, pagination, or regression coverage; tests were not run.
0 open findings
What changed in this PR
Moves Apps SDK global volume operations to the shared REST transport and /v2/global-volumes contract.
Changes:
- Lists volumes across all cursor pages.
- Sends creation requests once and removes obsolete GraphQL definitions.
- Adds regression coverage for pagination, resolution, and error propagation.
| File | Description |
|---|---|
| tests/鈥媡est_apps/鈥媡est_api_client.py | Tests REST calls, pagination, resolution, and single-attempt creation. |
| runpod/鈥媋pps/鈥媋pi.py | Routes global volume listing and creation through REST. |
| runpod/鈥媋pi/鈥媞ueries/鈥媋pps.py | Removes the obsolete global volume query. |
| runpod/鈥媋pi/鈥媘utations/鈥媋pps.py | Removes the obsolete global volume mutation. |
馃 Review effort: Balanced
馃挕 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
deanq
reviewed
Oct 15, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Route Apps SDK global volume listing and creation through the shared REST transport and
/v2/global-volumescontract from runpod/rphttp2#348. Follow every cursor page so volume resolution sees all matching IDs and names, and send creation requests once to avoid duplicate volumes after ambiguous failures