Conversation
I want to start porting this to prism without the translation layer.
Allows to remove some compatibility code with ripper
Maybe ripper fixed it since then. But prism also doesn't have this problem.
I had a bit of trouble following what is going on. Lexing produces tokens, this renames to reflect that.
Also add tests for the other types which currently don't have one
Earlopain
force-pushed
the
use-native-prism
branch
3 times, most recently
from
72b8a10 to
328a73b
Compare
It mostly continues to rely on tokens. But for a few things like endless method defs and multiline method continuations it uses AST. These are either very difficult or not possible to find just by checking tokens. Because of multiline method calls, comments now don't need to be trimmed anymore.
Earlopain
force-pushed
the
use-native-prism
branch
from
328a73b to
9f81d68
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP to check CI with older prism versions. Depends on other PRs, might do some extra cleanup