Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 21 additions & 1 deletion lib/lrama/lexer/token/user_code.rb
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,11 @@ def _references
when reference = scan_reference(scanner)
references << reference
when scanner.scan(/\/\*/)
scanner.scan_until(/\*\//)
scanner.scan_until(/\*\//) || scanner.terminate
when scanner.scan(%r{//})
scanner.scan_until(/\n/) || scanner.terminate
when quote = scanner.scan(/["']/)
skip_quoted_literal(scanner, quote)
else
scanner.getch
end
Expand All @@ -35,6 +39,22 @@ def _references
references
end

# @rbs (StringScanner scanner, String quote) -> void
def skip_quoted_literal(scanner, quote)
escaped = false

until scanner.eos?
char = scanner.getch
if escaped
escaped = false
elsif char == "\\"
escaped = true
elsif char == quote
break
end
end
end

# @rbs (StringScanner scanner) -> Lrama::Grammar::Reference?
def scan_reference(scanner)
start = scanner.pos
Expand Down
3 changes: 3 additions & 0 deletions sig/generated/lrama/lexer/token/user_code.rbs

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

15 changes: 15 additions & 0 deletions spec/lrama/lexer/token/user_code_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -58,5 +58,20 @@
expect(references.count).to eq 1
expect(references[0]).to eq Lrama::Grammar::Reference.new(type: :at, name: "expr.right", ex_tag: nil, first_column: 1, last_column: 14)
end

it "ignores references in C literals and comments" do
code = <<~'C'
$1;
printf("total $2 and @2 \"done\"");
int character = '$3';
// note $3 and @3
$4; @4;
/* note $5 and @5 */
C

references = Lrama::Lexer::Token::UserCode.new(s_value: code, location: location).references

expect(references.map { |ref| [ref.type, ref.index] }).to eq([[:dollar, 1], [:dollar, 4], [:at, 4]])
end
end
end