fix: Remediate eslint + ts smells#148
Open
justlevine wants to merge 2 commits intoscaffold-php-fixesfrom
Open
Conversation
justlevine
force-pushed
the
scaffold-eslint-fixes
branch
from
664040a to
3ab2ec8
Compare
justlevine
force-pushed
the
scaffold-eslint-fixes
branch
from
3ab2ec8 to
da0921a
Compare
justlevine
force-pushed
the
scaffold-eslint-fixes
branch
from
da0921a to
ba88c35
Compare
up1512001
reviewed
Mar 9, 2026
| process.cwd(), | ||
| 'tests/_output' | ||
| ); | ||
| const artifactsPath = path.join( process.cwd(), 'tests/_output/e2e' ); |
Member
There was a problem hiding this comment.
Just curious to know what benefit this path change will give us??
Collaborator
Author
There was a problem hiding this comment.
so it doesn't clobber or conflict with the other things in test/_output. other logs, but more annoyingly the .gitkeep.
up1512001
reviewed
Mar 9, 2026
Member
up1512001
left a comment
up1512001
left a comment
There was a problem hiding this comment.
@justlevine overall looks good just one question about path change.
up1512001
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes All eslint and typescript smells in the repo.
Important
This PR is based on #147, which should be merged first
Technical Details
OpenCode Prompt:
When completed and reviewed:
Checklist
Screenshots
To-do
Fixes/Covers issue
Fixes #