Skip to content

Use ament_set_default_language_standards from ament_cmake_core#548

Open
ahcorde wants to merge 2 commits intorollingfrom
ahcorde/rolling/cmake_language_standard
Open

Use ament_set_default_language_standards from ament_cmake_core#548
ahcorde wants to merge 2 commits intorollingfrom
ahcorde/rolling/cmake_language_standard

Conversation

@ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Mar 23, 2026

Description

Related with ament/ament_cmake#621

@ahcorde
Use ament_set_default_language_standards from ament_cmake_core
8630964 
Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
@ahcorde ahcorde requested a review from InvincibleRMC March 23, 2026 15:39
@ahcorde ahcorde self-assigned this Mar 23, 2026
@ahcorde
Copy link
Contributor Author

ahcorde commented Mar 23, 2026

Pulls: #548, ament/ament_cmake#621
Gist: https://gist.githubusercontent.com/ahcorde/625e52fa23a766ff8fae9be37ad3ad47/raw/d820803942e8a156af42db30a04fcb6309347102/ros2.repos
BUILD args: --packages-above-and-dependencies ament_cmake_core rcutils
TEST args: --packages-above ament_cmake_core rcutils
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/18622

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde ahcorde mentioned this pull request Mar 23, 2026
Closed
fujitatomoya
fujitatomoya approved these changes Mar 24, 2026
View reviewed changes
Copy link
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

much better, lgtm!

@ahcorde
use ament_cmake_ros
cbb1ee1 
Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
@ahcorde
Copy link
Contributor Author

ahcorde commented Mar 26, 2026

Pulls: #548, ros2/ament_cmake_ros#62
Gist: https://gist.githubusercontent.com/ahcorde/3e7ab21988cdd588ff217c5561a8ba80/raw/bd52d1d2df3a4da8b2da4f06ef3ebf0a122e7a70/ros2.repos
BUILD args: --packages-above-and-dependencies ament_cmake_ros rcutils rmw_test_fixture_implementation
TEST args: --packages-above ament_cmake_ros rcutils rmw_test_fixture_implementation
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/18675

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde ahcorde mentioned this pull request Mar 26, 2026
Open
InvincibleRMC
InvincibleRMC reviewed Mar 26, 2026
View reviewed changes
CMakeLists.txt
include(CheckLibraryExists)

find_package(ament_cmake REQUIRED)
find_package(ament_cmake_ros REQUIRED)
Copy link

@InvincibleRMC InvincibleRMC Mar 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the failures are from this.

Suggested change
find_package(ament_cmake_ros REQUIRED)

Copy link

@InvincibleRMC InvincibleRMC Mar 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this package doesn't have ament_cmake_ros in the package.xml but, it isn't needed anyway just ament_cmake_ros_core is enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@InvincibleRMC InvincibleRMC InvincibleRMC left review comments

@fujitatomoya fujitatomoya fujitatomoya approved these changes

Assignees

@ahcorde ahcorde

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ahcorde @InvincibleRMC @fujitatomoya