Skip to content

[RF][HS3] Fix export of self_normalized flag - #22889

Merged
guitargeek merged 1 commit into
root-project:masterfrom
Phmonski:fix/hs3-patch
Jul 28, 2026
Merged

[RF][HS3] Fix export of self_normalized flag#22889
guitargeek merged 1 commit into
root-project:masterfrom
Phmonski:fix/hs3-patch

Conversation

@Phmonski

Copy link
Copy Markdown
Contributor

This Pull request:

The selfNormalized() flag in the RooWrapperPdf importer and exporter keys didn't match.

Changes or fixes:

Set the export key to self_normalized and retain the legacy import of the selfnormalized key

@guitargeek

@guitargeek guitargeek changed the title [HS3] Fix export of self_normalized flag [RF][HS3] Fix export of self_normalized flag Jul 26, 2026
@github-actions

github-actions Bot commented Jul 26, 2026

Copy link
Copy Markdown

Test Results

    2 files      2 suites   2h 7m 57s ⏱️
2 599 tests 2 599 ✅ 0 💤 0 ❌
4 884 runs  4 884 ✅ 0 💤 0 ❌

Results for commit 221763b.

♻️ This comment has been updated with latest results.

@guitargeek

Copy link
Copy Markdown
Contributor

Hi! @Phmonski, you accidentally deleted testRooFitHS3.cxx. Can you bring it back?

@Phmonski

Copy link
Copy Markdown
Contributor Author

Wow, how did i manage that?! :D I fixed it.

@guitargeek guitargeek left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@guitargeek
guitargeek merged commit 8e8f30e into root-project:master Jul 28, 2026
30 of 31 checks passed
@guitargeek

Copy link
Copy Markdown
Contributor

/backport to 6.40

@root-project-bot

Copy link
Copy Markdown

Preparing to backport PR #22889 to branch 6.40 requested by guitargeek

@root-project-bot

Copy link
Copy Markdown

This PR has been backported to branch 6.40: #22944

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants