[civetweb] download instead of bundle, bump from 1.15 to 1.16, and define proper CMake target#21947
Open
ferdymercury wants to merge 14 commits intoroot-project:masterfrom
Open
[civetweb] download instead of bundle, bump from 1.15 to 1.16, and define proper CMake target#21947ferdymercury wants to merge 14 commits intoroot-project:masterfrom
ferdymercury wants to merge 14 commits intoroot-project:masterfrom
Conversation
Test Results2 579 tests 2 579 ✅ 1h 0m 6s ⏱️ Results for commit 88b2815. |
ferdymercury
commented
Apr 20, 2026
| ${FASTCGI_LIBRARY} | ||
| ${CMAKE_DL_LIBS} | ||
| civetweb::civetweb | ||
| DEPENDENCIES |
Collaborator
Author
There was a problem hiding this comment.
TO-DO: discuss if builtin_civetweb=OFF should be discouraged, by emitting a warning or better describing ROotBuildOptions text.
See discussion root-project/root-ci-images#110 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.