[unuran] download instead of bundle builtin and use CMake target#21938
[unuran] download instead of bundle builtin and use CMake target#21938ferdymercury wants to merge 4 commits intoroot-project:masterfrom
Conversation
|
thanks for this PR. The externals can be divided more or less in two categories: "easy" and "hard". In the "easy" category, one finds the ones that are easily installable via package managers, on linux or with Brew on mac. Unfortunately, Unuran is not "easy". Making it downloaded is certainly an opportunity to seize, maybe not immediately, since the package would not be easily available to users. |
Test Results 22 files 22 suites 3d 1h 57m 33s ⏱️ Results for commit 009ad0c. ♻️ This comment has been updated with latest results. |
Yep. Ubuntu 22 does not have it. But Ubuntu 24 and 26 now have libunuran-dev package. I think the current PR is now mature for review, it seems to build on all platforms. A variant using LCG link with a smaller patch is here: #21946 |
No description provided.