[hist] improve hist101_TH1_autobinning#21931
Merged
silverweed merged 2 commits intoroot-project:masterfrom Apr 20, 2026
Merged
Conversation
ferdymercury
approved these changes
Apr 16, 2026
Collaborator
ferdymercury
left a comment
ferdymercury
left a comment
There was a problem hiding this comment.
Looks great, thanks a lot!
I would just suggest to additionally document in doxygen's TH1.cxx / TH2.cxx / TH3.cxx :
-/// \param[in] xup upper edge of last bin (not included in last bin)
+/// \param[in] xup upper edge of last bin (not included in last bin)
+/// \note if xup <= xin, automatic bins are calculated when buffer size is reached
+/// @see TH1::BufferEmpty
Try to explain what's going on so the user has more chances to understand the tutorial.
silverweed
force-pushed
the
autobinning_tutorial
branch
from
4275827 to
80d59c8
Compare
Test Results 22 files 22 suites 3d 8h 43m 49s ⏱️ For more details on these failures, see this check. Results for commit 80d59c8. |
dpiparo
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Try to explain what's going on so the user has more chances to understand the tutorial.