[Math] Protect against C == nullptr in SOFIE::Gemm_Call pullback#21490
Merged
guitargeek merged 1 commit intoroot-project:masterfrom Mar 9, 2026
Merged
[Math] Protect against C == nullptr in SOFIE::Gemm_Call pullback#21490guitargeek merged 1 commit intoroot-project:masterfrom
C == nullptr in SOFIE::Gemm_Call pullback#21490guitargeek merged 1 commit intoroot-project:masterfrom
Conversation
It's possible to call `gemm` without a `C` parameter (constant offset), so the custom derivative can't assume that `C` and `_d_C` are always set. This avoids segfaults when `C` is `nullptr`.
guitargeek
changed the title
C=nullptr in SOFIE::Gemm_Call pullbackC == nullptr in SOFIE::Gemm_Call pullback
Test Results 22 files 22 suites 3d 7h 57m 45s ⏱️ For more details on these failures, see this check. Results for commit 00b413c. |
Contributor
|
How hot is this |
Contributor
Author
|
Thanks for the review! The loop is not very hot. The expensive part of the function is the matrix multiplication just before the loop over the offsets |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's possible to call
gemmwithout aCparameter (constant offset), so the custom derivative can't assume thatCand_d_Care always set.This avoids segfaults when
Cisnullptr.