[tmva][sofie] Remove unsafe RModel::AddOperatorReference interface#21456
Merged
guitargeek merged 1 commit intoroot-project:masterfrom Mar 3, 2026
Merged
[tmva][sofie] Remove unsafe RModel::AddOperatorReference interface#21456guitargeek merged 1 commit intoroot-project:masterfrom
RModel::AddOperatorReference interface#21456guitargeek merged 1 commit intoroot-project:masterfrom
Conversation
The `RModel::AddOperatorReference()` function is not memory safe, because it takes ownership of an argument passed by raw pointer. It's better to remove these kind of functions (possible because SOFIE is still in the experimental namespace), and use the safe alternative that take a `std::unique_ptr` instead, for clear ownership semantics.
Test Results 22 files 22 suites 3d 2h 3m 28s ⏱️ Results for commit 086e092. |
lmoneta
approved these changes
Mar 3, 2026
Member
lmoneta
left a comment
lmoneta
left a comment
There was a problem hiding this comment.
Thank you Jonas for fixing this.
AddOperatorReference was added for Python, but your solution is a better one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
RModel::AddOperatorReference()function is not memory safe, because it takes ownership of an argument passed by raw pointer. It's better to remove these kind of functions (possible because SOFIE is still in the experimental namespace), and use the safe alternative that take astd::unique_ptrinstead, for clear ownership semantics.