[tmva][sofie] Don't mutate Session data data member in NonZero operator#21452
Closed
guitargeek wants to merge 1 commit intoroot-project:masterfrom
Closed
[tmva][sofie] Don't mutate Session data data member in NonZero operator#21452guitargeek wants to merge 1 commit intoroot-project:masterfrom
guitargeek wants to merge 1 commit intoroot-project:masterfrom
Conversation
There is a logic error in the code emitted for the NonZero operator because the same variable is used for the maximum dynamic shape that is stored as the sesssion data member and as a "local variable" in the inferenence function. These should be separate variables to avoid mutating the Session object on inference.
Test Results 20 files 20 suites 2d 20h 9m 40s ⏱️ For more details on these failures, see this check. Results for commit 2ecd1c8. |
Contributor
Author
|
Replaced by #21458 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a logic error in the code emitted for the NonZero operator because the same variable is used for the maximum dynamic shape that is stored as the sesssion data member and as a "local variable" in the inferenence function. These should be separate variables to avoid mutating the Session object on inference.