Skip to content

[roottest] Use with MsDev the mechanism that allows a single build to run in parallel with tests.#21358

Merged
pcanal merged 5 commits intoroot-project:masterfrom
pcanal:msdev_vs_roottest
Mar 10, 2026
Merged

[roottest] Use with MsDev the mechanism that allows a single build to run in parallel with tests.#21358
pcanal merged 5 commits intoroot-project:masterfrom
pcanal:msdev_vs_roottest

Conversation

@pcanal
Copy link
Member

@pcanal pcanal commented Feb 23, 2026

As seen https://github.com/root-project/root/pull/21192/checks?check_run_id=64082830177, when using the visual studio generator we seem to have a problem similar to the issue solved in #19702.

See the test history of this PR.

@pcanal pcanal requested a review from hageboeck February 23, 2026 23:00
@pcanal pcanal self-assigned this Feb 23, 2026
@pcanal pcanal requested a review from bellenot as a code owner February 23, 2026 23:00
@github-actions
Copy link

github-actions bot commented Feb 24, 2026

Test Results

    22 files      22 suites   3d 4h 9m 47s ⏱️
 3 819 tests  3 818 ✅ 1 💤 0 ❌
76 506 runs  76 497 ✅ 9 💤 0 ❌

Results for commit 9fecf21.

♻️ This comment has been updated with latest results.

@pcanal pcanal force-pushed the msdev_vs_roottest branch from e97b845 to 246fdeb Compare March 9, 2026 13:45
pcanal added 3 commits March 9, 2026 13:08
When using the Microsoft Visual Studio generator we have the exact same problem,
that it might trigger a rebuild of ROOT so we need to apply the same solution.

See 06e00a2.

PS. We might want to eventually rename the resource lock.

Add missing config to the build target (required on Windows)
It is need by at least Ninja and the Visual Studio generator
@pcanal pcanal force-pushed the msdev_vs_roottest branch from 246fdeb to 222ccc3 Compare March 9, 2026 18:08
Copy link
Member

@bellenot bellenot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and it seems to be working now. Thanks Philippe!

@pcanal pcanal merged commit 16dd7f2 into root-project:master Mar 10, 2026
30 checks passed
@pcanal pcanal deleted the msdev_vs_roottest branch March 10, 2026 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants