Add tests for std::[unordered_][multi]map#62
Open
enirolf wants to merge 4 commits intoroot-project:mainfrom
Open
Add tests for std::[unordered_][multi]map#62enirolf wants to merge 4 commits intoroot-project:mainfrom
std::[unordered_][multi]map#62enirolf wants to merge 4 commits intoroot-project:mainfrom
Conversation
hahnjo
reviewed
Mar 6, 2026
Member
hahnjo
left a comment
hahnjo
left a comment
There was a problem hiding this comment.
Looks very good already! One minor question about the documented column types and I think we need to sort the unordered associative containers
types/map/fundamental/README.md
Outdated
| - `[Split]Index{32,64}` | ||
|
|
||
| with the corresponding column type for the offset column of the collection parent field. | ||
| All child fields use the default column types for `std::string` (`SplitIndex64` for the principal column, `Char` for the second column) and `std::int32_t` (`SplitInt32`). |
Member
There was a problem hiding this comment.
Are you sure? Since we are writing without compression, the defaults should be Index64 and Int32 I believe
Contributor
Author
There was a problem hiding this comment.
Ah you're right, forgot we are not compressing :)
| static void PrintNestedUnorderedMapValue(const REntry &entry, | ||
| std::string_view name, | ||
| std::ostream &os, bool last = false) { | ||
| UnorderedMap &item = *entry.GetPtr<UnorderedMap>(name); |
Member
There was a problem hiding this comment.
I think as for std::unordered_set, we need to sort the (key, value) pairs by key before printing
|
|
||
| static void PrintMultimapValue(const REntry &entry, std::string_view name, | ||
| std::ostream &os, bool last = false) { | ||
| UnorderedMultimap &item = *entry.GetPtr<UnorderedMultimap>(name); |
Member
There was a problem hiding this comment.
same here for std::unordered_multimap
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #13