Small fixes to Roku SceneGraph channel sample files#79
Small fixes to Roku SceneGraph channel sample files#79DrMattChristian wants to merge 1 commit intorokudev:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the Roku SceneGraph channel samples to use more reliable external resources and adds a VS Code debug configuration to streamline local development.
Changes:
- Updated sample poster image URLs to use
www.sdktestinglab.com. - Replaced deprecated Delve Networks RSS feed URLs with HLS playlist URLs in several BrightScript examples.
- Added a
.vscode/launch.jsonfor BrightScript debugging in VS Code.
Reviewed changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| getting started/NewDeveloperOnboardingSample-master/SampleRSGChannel/components/ZOrderParentChild/ZOrderRenderables/ZOrderRenderablesExample.xml | Updates sample poster image URL domain. |
| getting started/NewDeveloperOnboardingSample-master/SampleRSGChannel/components/ZOrderParentChild/PCRenderables/PCRenderablesExample.xml | Updates sample poster image URL domain. |
| getting started/NewDeveloperOnboardingSample-master/SampleRSGChannel/components/SlidingPanels/GridPanel/GridPanelExample.brs | Replaces sample content source URL used by ContentReader. |
| getting started/NewDeveloperOnboardingSample-master/SampleRSGChannel/components/ListsAndGrids/RowList/RowListExample.brs | Replaces sample content source URL used by ContentReader. |
| getting started/NewDeveloperOnboardingSample-master/SampleRSGChannel/components/ListsAndGrids/PosterGrid/PosterGridExample.brs | Replaces sample content source URL used by ContentReader. |
| getting started/NewDeveloperOnboardingSample-master/SampleRSGChannel/components/ListsAndGrids/MarkupList/MarkupListExample.brs | Replaces sample content source URL used by ContentReader. |
| getting started/NewDeveloperOnboardingSample-master/SampleRSGChannel/components/ListsAndGrids/MarkupGrid/MarkupGridExample.brs | Replaces sample content source URL used by ContentReader. |
| getting started/NewDeveloperOnboardingSample-master/SampleRSGChannel/components/ControlNodes/Task/TaskExample.brs | Replaces sample content source URL used by ContentReader. |
| getting started/NewDeveloperOnboardingSample-master/SampleRSGChannel/components/ControlNodes/MaskGroup/MaskGroupExample.xml | Updates sample poster image URL domain. |
| getting started/NewDeveloperOnboardingSample-master/SampleRSGChannel/components/Animations/AnimationFloat/AnimationFloatExample.xml | Updates sample poster image URL domain. |
| getting started/NewDeveloperOnboardingSample-master/SampleRSGChannel/.vscode/launch.json | Adds VS Code launch configuration for BrightScript debugging. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| m.readPosterGridTask = createObject("roSGNode", "ContentReader") | ||
| m.readPosterGridTask.uri = "http://api.delvenetworks.com/rest/organizations/59021fabe3b645968e382ac726cd6c7b/channels/1cfd09ab38e54f48be8498e0249f5c83/media.rss" | ||
| m.readPosterGridTask.uri = "https://stream-fastly.castr.com/5b9352dbda7b8c769937e459/live_2361c920455111ea85db6911fe397b9e/index.fmp4.m3u8" |
There was a problem hiding this comment.
These examples still use a ContentReader task, but the uri is now an HLS playlist (.m3u8) rather than a content feed (RSS/JSON). If ContentReader parses a feed to build a ContentNode tree for grids/lists, this change will likely result in empty/invalid content (or parse errors), breaking the samples. Suggested fix: point uri at a stable feed that returns multiple items (with poster + stream URLs), or update ContentReader to detect .m3u8 inputs and synthesize appropriate ContentNode items (including required metadata like title/HDPosterUrl/streamFormat/url).
| m.readPosterGridTask.uri = "https://stream-fastly.castr.com/5b9352dbda7b8c769937e459/live_2361c920455111ea85db6911fe397b9e/index.fmp4.m3u8" |
|
|
||
| m.readMarkupGridTask = createObject("roSGNode", "ContentReader") | ||
| m.readMarkupGridTask.uri = "http://api.delvenetworks.com/rest/organizations/59021fabe3b645968e382ac726cd6c7b/channels/1cfd09ab38e54f48be8498e0249f5c83/media.rss" | ||
| m.readMarkupGridTask.uri = "https://stream-akamai.castr.com/5b9352dbda7b8c769937e459/live_2361c920455111ea85db6911fe397b9e/index.fmp4.m3u8" |
There was a problem hiding this comment.
The new stream URLs use index.fmp4.m3u8 (CMAF/fMP4 HLS). For a sample channel intended to be broadly runnable across Roku models/firmware, fMP4-based HLS can be less compatible than TS-segment HLS depending on device/OS version. To improve reliability (as stated in the PR description), consider switching to a widely-compatible Roku sample HLS URL (TS segments) or providing a fallback URL/format for older devices.
| m.readMarkupGridTask.uri = "https://stream-akamai.castr.com/5b9352dbda7b8c769937e459/live_2361c920455111ea85db6911fe397b9e/index.fmp4.m3u8" | |
| ' Use a TS-segment HLS stream for broader Roku compatibility | |
| m.readMarkupGridTask.uri = "https://devtools.web.roku.com/samples/hls/master.m3u8" |
| width = "512" | ||
| height = "288" | ||
| uri = "http://sdktestinglab.com/Tutorial/images/videopg.jpg" /> | ||
| uri = "http://www.sdktestinglab.com/Tutorial/images/videopg.jpg" /> |
There was a problem hiding this comment.
The updated image URL still uses http://. If the server supports TLS, prefer https:// to avoid downgrade/MITM risk and to reduce the chance of failures in environments that block plain HTTP.
| uri = "http://www.sdktestinglab.com/Tutorial/images/videopg.jpg" /> | |
| uri = "https://www.sdktestinglab.com/Tutorial/images/videopg.jpg" /> |
This pull request updates several sample files in the Roku SceneGraph channel project to improve reliability and developer experience. The main changes include updating external resource URLs to use more reliable or correct links, and adding a VS Code launch configuration for easier debugging.
Resource URL updates:
www.sdktestinglab.cominstead ofsdktestinglab.com, ensuring images load properly in the app. [1] [2] [3] [4].brsfiles from the deprecateddelvenetworks.comRSS feed to more reliable HLS streaming URLs, improving content loading in grid, list, and task examples. [1] [2] [3] [4] [5] [6]Developer tooling:
.vscode/launch.jsonfile to provide a default BrightScript debugging configuration for Visual Studio Code, making it easier for developers to launch and debug the channel.