Conversation
CMake/vtkWheelPreparation.cmake defaults VTK_VERSION_SUFFIX to 'dev0' and only skips it when $CI_COMMIT_TAG is set - upstream's own GitLab CI sets that for tag-triggered pipelines. Our GitHub Actions build checks out the exact v9.7.0 tag with a clean, unpatched tree, but without this override every wheel still gets versioned 9.7.0.dev0 instead of the clean 9.7.0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
vtkCMake/vtkWheelPreparation.cmakedefaultsVTK_VERSION_SUFFIXtodev0, only skipped when$CI_COMMIT_TAGis set — upstream's own GitLab CI sets that automatically for tag-triggered pipelines. Our build runs on GitHub Actions from the exactv9.7.0tag with a clean, unpatched tree, but without this override every wheel still gets versioned9.7.0.dev0instead of the clean9.7.0. Different root cause than the other version-pin PRs in this batch (asv/pynng/uharfbuzz/zlib-ng/nodejs-wheel-binaries) — those are a patch-dirtied-tree + setuptools_scm issue; this one is a CMake cache default gated on a GitLab-only CI variable.Fix: add
-DVTK_VERSION_SUFFIX=to the cmake configure args.License: OK, unchanged.