Conversation
…m dev version The riscv64 OpenSSL patch leaves the checkout dirty relative to the v24.19.0 tag; without SETUPTOOLS_SCM_PRETEND_VERSION, setuptools_scm (via scikit-build-core) computes the version from git state and produces a dev-suffixed local version instead of the clean 24.19.0 (published so far: 24.19.1.dev0+g0a3c599f0.d20260907/d20260908).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nodejs-wheel-binariesThe riscv64 OpenSSL patch (adding
--openssl-no-asmto Node's configure) leaves the checkout dirty relative to thev24.19.0tag. Upstream usessetuptools_scmviascikit-build-corefor dynamic versioning, so a dirty tree produced a bumped, dev-suffixed local version on every publish so far (24.19.1.dev0+g0a3c599f0.d20260907/.d20260908) instead of the clean24.19.0.Fix: add
CIBW_ENVIRONMENT: SETUPTOOLS_SCM_PRETEND_VERSION=...(this workflow previously set noCIBW_ENVIRONMENTat all).License: OK, unchanged.