feat(sdk/go): complete Go SDK with domain clients, auth, and hardening (Drop B) - #19
Closed
rhuss wants to merge 1 commit into
Closed
feat(sdk/go): complete Go SDK with domain clients, auth, and hardening (Drop B)#19rhuss wants to merge 1 commit into
rhuss wants to merge 1 commit into
Conversation
|
Important Review skippedToo many files! This PR contains 278 files, which is 178 over the limit of 100. To get a review, reduce the PR to 100 files or fewer by splitting it into smaller PRs or changing its base branch. Upgrade to a paid plan to raise the limit. This review couldn't start because sufficient usage credits or metered capacity aren't available. Add credits or update usage-based reviews in the billing tab, then retry. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (7)
📒 Files selected for processing (278)
You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
rhuss
force-pushed
the
go-sdk-b-complete
branch
from
August 11, 2026 05:58
2a203d7 to
4a252dc
Compare
Add the Go SDK implementation covering all gateway RPC services with domain-typed clients, comprehensive OIDC authentication flows, fake test doubles, and proto converters. Domain clients: Sandbox, Provider, Exec, File, TCP, SSH, Policy, Profile, Health, Service, Config, Workspace, Inference, Refresh. Each client validates inputs, resolves sandboxes by name, and converts between domain types and proto at the boundary. Auth: OIDC authorization code (PKCE), device code (RFC 8628), and client credentials (RFC 6749 Section 4.4) flows with gateway config auto-resolution. Token refresh with singleflight deduplication and exponential backoff. Edge tunnel proxy for gRPC-over-WebSocket. Gateway: On-disk gateway discovery with user/system directory precedence, lazy token loading, and auth mode mapping. Testing: In-memory fake client with deep-copy isolation, watch broadcasting with filtering, and workspace-scoped object stores. Bufconn-based gRPC tests for all domain clients. Ref: NVIDIA#2044 Signed-off-by: Roland Huß <rhuss@redhat.com>
rhuss
force-pushed
the
go-sdk-b-complete
branch
from
August 11, 2026 12:31
61f9432 to
3e46ae8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Complete the Go SDK contribution (Drop B) building on the foundation from Drop A (PR NVIDIA#2271):
All changes target
sdk/go/. CI integration follows in a subsequent PR.Ref NVIDIA#2044
Reviewer Verification Checklist
cd sdk/go && mise run cipasses (lint + build + test + docs:check)grep -r 'rhuss/openshell-sdk-go' sdk/go/returns zero matchesgit diff --stat | tail -1shows 212 files changedcontext_errors.goexists (renamed fromgrpc_errors.go)conn.gorejects TLS params with plaintext addresssandbox_client.gohascheckTerminalPhasehelperGetOptions,DeleteOptions,UpdateOptions,RetryPolicystructs;CreateOptionskept (actively used with Annotations field)internal/converter/).gofiles have SPDX Apache-2.0 headers; config files have upstream SPDX headersTest plan
mise run cipasses: lint (0 issues), build, test (all packages), proto:check, docs:checkgrep -r 'rhuss/openshell-sdk-go' sdk/go/returns empty)